fix: Skip preparation of plugins native files in case they are not changed #3768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add logging in projectChangesService's checkForChanges method in order to know which files are changed. This will help us to understand why prepare is triggered.
rosen-vladimirov
force-pushed
the
vladimirov/checkForChanges-logging
branch
2 times, most recently
from
ef0070f to
92cf983
Compare
Fatme
reviewed
Jul 23, 2018
| this._changesInfo.modulesChanged = true; | ||
| } | ||
| if (this._changesInfo.modulesChanged || this._changesInfo.appResourcesChanged) { | ||
| this.$logger.trace(`Set configChanged to true, current value of moduleChanged is: ${this._changesInfo.modulesChanged}, appResourcesChanged is: ${this._changesInfo.appResourcesChanged}`); |
There was a problem hiding this comment.
Maybe it is better to print all changesInfo.
There was a problem hiding this comment.
It is printed at the end of the method. Or you want to know the value of the properties before setting all of them to true?
There was a problem hiding this comment.
Actually I just want to see all changesInfo and didn't notice it is printed at the end of the method.
test/plugins-service.ts
Outdated
| assert.deepEqual(testData.dataPassedToWriteJson, { [testData.pluginData.name]: newPluginHashes }); | ||
| }); | ||
|
|
||
| it("does not prepare the files when plugin has platforms dir and has files has not changed since then", async () => { |
There was a problem hiding this comment.
Maybe
has files that are not changed since then?
rosen-vladimirov
force-pushed
the
vladimirov/checkForChanges-logging
branch
from
92cf983 to
d159572
Compare
…anged Skip the preparation of plugins' native files in case there's no change of the files since last operation when the files have been prepared. Do this by using hash sums of files in each plugin's `platforms/<platform>` dir in case such exists. This way, in case you apply a change outside of the `<plugin dir>/platforms/<platform>` dir, the plugin's native files will not be prepared again. This way application will not be rebuilt as there's no need to do this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip the preparation of plugins' native files in case there's no change of the files since last operation when the files have been prepared.
Do this by using hash sums of files in each plugin's
platforms/<platform>dir in case such exists. This way, in case you apply a change outside of the<plugin dir>/platforms/<platform>dir, the plugin's native files will not be prepared again. This way application will not be rebuilt as there's no need to do this.chore: Add logging in projectChangesService
Add logging in projectChangesService's checkForChanges method in order to know which files are changed. This will help us to understand why prepare is triggered.
PR Checklist
What is the current behavior?
Whenever a change in
node_modulesis detected, CLI prepares the native resources. For example this leads to regeneration of Podfile whenever a change in.jsor even.cssinsidenode_modulesis detected.What is the new behavior?
CLI persists shasums for each plugin's native part. In case the plugin's native part is not changed, CLI will not prepare the native resources of the plugin itself.
Partial fix for #3549