Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prompter for mail on postinstall is very obligatory #3878

Merged
merged 1 commit into from
Sep 11, 2018

Conversation

rosen-vladimirov
Copy link
Contributor

On postinstall CLI checks if the user had subscribed for NativeScript newsletter if not, prompts for email. However, the messages seems obligatory, while it is not.
Reformat it, so the users can easily skip it in case they do not want to subscribe for the newsletter.

PR Checklist

What is the current behavior?

The prompter on postinstall seems mandatory.

What is the new behavior?

The prompter on postinstall does not seem so mandatory.

Fixes/Implements/Closes #[Issue Number].

@rosen-vladimirov rosen-vladimirov added this to the 5.0.0 milestone Sep 10, 2018
@rosen-vladimirov rosen-vladimirov self-assigned this Sep 10, 2018
@rosen-vladimirov
Copy link
Contributor Author

run ci

On postinstall CLI checks if the user had subscribed for NativeScript newsletter if not, prompts for email. However, the messages seems obligatory, while it is not.
Reformat it, so the users can easily skip it in case they do not want to subscribe for the newsletter.
@rosen-vladimirov rosen-vladimirov force-pushed the vladimirov/fix-postinstall-prompter branch from 86a610d to 465b836 Compare September 11, 2018 08:22
@rosen-vladimirov rosen-vladimirov merged commit 75eae2c into master Sep 11, 2018
@rosen-vladimirov rosen-vladimirov deleted the vladimirov/fix-postinstall-prompter branch September 11, 2018 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants