fix: prepare node_modules only once #4011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever we prepare node_modules (i.e. moving them to platforms dir), CLI executes the operation twice: 1. When prepare the JS part of the modules. 2. When prepare the native part of the modules. The first part is a must for cases when you work with cloud builds, so we cannot skip it, but we can safely skip the second one. This improves the initial prepare of `tns-template-master-detail-ng` with around 20 seconds.
DimitarTachev
approved these changes
Oct 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever we prepare node_modules (i.e. moving them to platforms dir), CLI executes the operation twice:
The first part is a must for cases when you work with cloud builds, so we cannot skip it, but we can safely skip the second one. This improves the initial prepare of
tns-template-master-detail-ngwith around 20 seconds.PR Checklist
What is the current behavior?
Node_modules are prepared twice on first
tns runWhat is the new behavior?
Node_modules are prepared once.
Fixes issue #4010