fix: remove persisted emulator's data on deviceLost event #4055
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user starts an android emulator from sidekick, {N} CLI persist the emulator in a dictionary. The started emulator is with id
emulator-5554
so {N} CLI adds a record with keyemulator-5554
in the dictionary.If the user stops the emulator and starts an another one, the started emulator is again with id
emulator-5554
. {N} CLI checks that an emulator with idemulator-5554
is persisted and returns the emulator's data. But the returned data is not correct because it belongs to the first started emulator. So we need to remove persisted emulator's data when the user stops the emulator (e.g deviceLost event is emitted).PR Checklist
What is the current behavior?
The emulator's data is not removed on deviceLost event
What is the new behavior?
The emulator's data is removed on deviceLost event