Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove persisted emulator's data on deviceLost event #4055

Merged
merged 1 commit into from
Oct 24, 2018

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented Oct 24, 2018

If the user starts an android emulator from sidekick, {N} CLI persist the emulator in a dictionary. The started emulator is with id emulator-5554 so {N} CLI adds a record with key emulator-5554 in the dictionary.
If the user stops the emulator and starts an another one, the started emulator is again with id emulator-5554. {N} CLI checks that an emulator with id emulator-5554 is persisted and returns the emulator's data. But the returned data is not correct because it belongs to the first started emulator. So we need to remove persisted emulator's data when the user stops the emulator (e.g deviceLost event is emitted).

PR Checklist

What is the current behavior?

The emulator's data is not removed on deviceLost event

What is the new behavior?

The emulator's data is removed on deviceLost event

@Fatme Fatme added this to the 5.0.1 milestone Oct 24, 2018
@Fatme Fatme merged commit 76a362f into release-5.0.1 Oct 24, 2018
@Fatme Fatme deleted the fatme/fix-emulator-lost branch October 24, 2018 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants