Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't throw TypeError: Invalid Version: null in sidekick when emulator is stopped immediately after start #4056

Merged
merged 2 commits into from
Oct 24, 2018

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented Oct 24, 2018

TypeError: Invalid Version: null error is shown is Sidekick when emulator is stopped immediately after start. This happens because emulator is stopped too early and it is not fully initialized. In this case reported emulator is with version: null and the semver comparison fails. So we need to ensure the device's version is not null before comparison.

PR Checklist

What is the current behavior?

TypeError: Invalid Version: null error is thrown in Sidekick when emulator is stopped immediately after start.

What is the new behavior?

No error is thrown in Sidekick when emulator is stopped immediately after start.

@Fatme Fatme added this to the 5.0.1 milestone Oct 24, 2018
Copy link
Contributor

@rosen-vladimirov rosen-vladimirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After deciding what will happen if deviceInfo is null.

@Fatme Fatme merged commit f606374 into release-5.0.1 Oct 24, 2018
@Fatme Fatme deleted the fatme/fix-invalid-version-null branch October 24, 2018 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants