fix: don't throw TypeError: Invalid Version: null
in sidekick when emulator is stopped immediately after start
#4056
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeError: Invalid Version: null
error is shown is Sidekick when emulator is stopped immediately after start. This happens because emulator is stopped too early and it is not fully initialized. In this case reported emulator is withversion: null
and the semver comparison fails. So we need to ensure the device's version is notnull
before comparison.PR Checklist
What is the current behavior?
TypeError: Invalid Version: null
error is thrown in Sidekick when emulator is stopped immediately after start.What is the new behavior?
No error is thrown in Sidekick when emulator is stopped immediately after start.