Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reset errors when fallback to list avds from directory #4079

Merged
merged 2 commits into from
Oct 30, 2018

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented Oct 29, 2018

When there are errors on avdmanager's stderr and no data on avdmanager's stdout, {N} CLI fallback to list avds from directory and returns both devices (from directory) and errors from avdmanager's stderr. However this is incorrect behavior. In case we fallback to list avds from directory, we need to reset errors output.

PR Checklist

What is the current behavior?

When there are errors on avdmanager's stderr and no data on avdmanager's stdout, {N} CLI fallback to list avds from directory and returns both devices (from directory) and errors from avdmanager's stderr

What is the new behavior?

When there are errors on avdmanager's stderr and no data on avdmanager's stdout, {N} CLI fallback to list avds from directory and returns devices (from directory) and no errors

@Fatme Fatme added this to the 5.0.1 milestone Oct 29, 2018
@Fatme
Copy link
Contributor Author

Fatme commented Oct 30, 2018

run ci

@Fatme Fatme merged commit 799cf45 into release-5.0.1 Oct 30, 2018
@Fatme Fatme deleted the fatme/fix-emulator-errors branch October 30, 2018 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants