Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(yarn): implement get cache directory path and remove npm --dry-run logic #4085

Merged
merged 2 commits into from
Nov 5, 2018

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented Nov 1, 2018

Remove the last hardcoded npm command so yarn will be used all the time when it is set as package manager. Also remove --dry run logic and use $pacoteService.manifest instead.

PR Checklist

rel to: #2737

Remove the last hardcoded `npm` command so yarn will be used all the time when it is set as package manager
@Fatme Fatme added this to the 5.1.0 milestone Nov 1, 2018
@Fatme Fatme changed the title feat(yarn): implement get cache directory path feat(yarn): implement get cache directory path and remove npm --dry-run logic Nov 1, 2018
@Fatme
Copy link
Contributor Author

Fatme commented Nov 2, 2018

run ci

@DimitarTachev DimitarTachev merged commit 308a370 into master Nov 5, 2018
@DimitarTachev DimitarTachev deleted the fatme/fix-yarn branch November 5, 2018 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants