Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix yarn view method to return correct data #4149

Merged
merged 1 commit into from
Nov 20, 2018
Merged

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented Nov 20, 2018

As --json flag is hardcoded for yarn info command, it always returns a json object in following format: { data: someResult }. As the other methods expect only someResult as a result from view command, we need to return .data property from yarn info output.

PR Checklist

What is the current behavior?

tns doctor does not return the correct components info when yarn is set as package manager.

What is the new behavior?

tns doctor returns the correct components info when yarn is set as package manager.

Fixes/Implements/Closes #[Issue Number].

Rel to: #2737

As --json flag is hardcoded for `yarn info` command, it always returns a json object in following format: { data: someResult }. As the other methods expect only `someResult` as a result from view command, we need to return `.data` property from `yarn info` output.
@Fatme Fatme added the no-changelog The issue is present only in `next` versions and was not included in official version. label Nov 20, 2018
@Fatme Fatme added this to the 5.1.0 milestone Nov 20, 2018
@Fatme Fatme self-assigned this Nov 20, 2018
@Fatme Fatme merged commit a14fd05 into master Nov 20, 2018
@Fatme Fatme deleted the fatme/fix-yarn-view branch November 20, 2018 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog The issue is present only in `next` versions and was not included in official version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants