Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix unhandled promise rejection error from sidekick when livesync to preview app with bundle #4251

Merged
merged 2 commits into from
Jan 3, 2019
Merged

fix: fix unhandled promise rejection error from sidekick when livesync to preview app with bundle #4251

merged 2 commits into from
Jan 3, 2019

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented Jan 2, 2019

PR Checklist

What is the current behavior?

An unhandled promise rejection error is thrown from sidekick when livesync to preview app with bundle

What is the new behavior?

An unhandled promise rejection error is not thrown from sidekick when livesync to preview app with bundle

@Fatme Fatme added this to the 5.1.1 milestone Jan 2, 2019
@Fatme
Copy link
Contributor Author

Fatme commented Jan 2, 2019

run ci

1 similar comment
@Fatme
Copy link
Contributor Author

Fatme commented Jan 2, 2019

run ci

@Fatme
Copy link
Contributor Author

Fatme commented Jan 2, 2019

run ci

1 similar comment
@dtopuzov
Copy link
Contributor

dtopuzov commented Jan 2, 2019

run ci

@Fatme Fatme merged commit 65eeeeb into release Jan 3, 2019
@Fatme Fatme deleted the fatme/fix-unhandled-rejection branch January 3, 2019 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosen-vladimirov rosen-vladimirov rosen-vladimirov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@Fatme @dtopuzov @rosen-vladimirov