feat: detect and report short imports used in application #4372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosen-vladimirov
force-pushed
the
vladimirov/short-imports-warn
branch
from
07ff1dc to
1be68fb
Compare
Fatme
reviewed
Feb 19, 2019
In NativeScript 5.2.0 we've deprecated support for short imports. Add ability in CLI to check if there are such imports in the application's code and report them to users. The logic will be executed whenever application is prepared for build/livesync or when `tns doctor` is executed inside project dir. Create class with static variables for ProjectTypes. These values must not be changed as they are used in Analytics, so changing them will break the current reports.
rosen-vladimirov
force-pushed
the
vladimirov/short-imports-warn
branch
from
1be68fb to
f50f22d
Compare
Fatme
reviewed
Feb 21, 2019
|
|
||
| for (const file of files) { | ||
| const fileContent = this.$fs.readText(file); | ||
| const strippedComments = helpers.stripComments(fileContent); |
KristianDD
approved these changes
Feb 21, 2019
|
run ci |
3 similar comments
|
run ci |
|
run ci |
|
run ci |
DimitarTachev
approved these changes
Feb 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In NativeScript 5.2.0 we've deprecated support for short imports. Add ability in CLI to check if there are such imports in the application's code and report them to users. The logic will be executed whenever application is prepared for build/livesync or when
tns doctoris executed inside project dir.Create class with static variables for ProjectTypes. These values must not be changed as they are used in Analytics, so changing them will break the current reports.
PR Checklist
What is the current behavior?
Users should search their own code for short imports.
What is the new behavior?
CLI warns users for used short imports in the application when
tns run <platform>ortns doctoris executed.Fixes issue #4375