Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: retry stuck requests #4426

Merged
merged 1 commit into from
Mar 11, 2019
Merged

Conversation

tsvetie
Copy link
Contributor

@tsvetie tsvetie commented Mar 11, 2019

Better fix than #4329

It is better to stop the timer once the handshake completes than to check the request type.

PR Checklist

What is the current behavior?

What is the new behavior?

Fixes/Implements/Closes #[Issue Number].

PUT and POST requests may hang as well.
@ghost ghost assigned tsvetie Mar 11, 2019
@cla-bot
Copy link

cla-bot bot commented Mar 11, 2019

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @tsvetie.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@ghost ghost added the new PR label Mar 11, 2019
@tsvetie tsvetie requested a review from TsvetanMilanov March 11, 2019 14:25
@cla-bot cla-bot bot removed the new PR label Mar 11, 2019
@tsvetie tsvetie added the bug label Mar 11, 2019
@tsvetie
Copy link
Contributor Author

tsvetie commented Mar 11, 2019

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Mar 11, 2019

The cla-bot has been summoned, and re-checked this pull request!

@cla-bot cla-bot bot added the cla: yes label Mar 11, 2019
@tsvetie tsvetie merged commit 0c28b3f into release Mar 11, 2019
@tsvetie tsvetie deleted the tivanova/fix-sporadic-hang-cloud-builds branch March 11, 2019 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants