Device/emulator detection fixes #4483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The emulator detection interval is not required for CLI and in fact it just uses CPU and memory. Also, it causes some issues when you do not hava JAVA installed. So remove start of emulator detection interval and allow it to be started from the API, when CLI is used as a library.
In case JAVA_HOME is not set and there's no java executable in PATH, calls to `avdmanager` fail with error. However, on macOS this also leads to system prompt to install JAVA. To handle this, do not execute `avdmanager` in case there's no JAVA_HOME or java in PATH.
ghost
added
the
rosen-vladimirov
changed the title
|
test cli-smoke |
Fatme
reviewed
Mar 29, 2019
Add clearInterval in timers API, so we can safely remove the cached timers from our internal cache. Without this, we end up calling many clearIntervals for timers that have already been cleared.
|
test cli-smoke |
Fatme
approved these changes
Mar 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: do not start emulator detection interval
The emulator detection interval is not required for CLI and in fact it just uses CPU and memory. Also, it causes some issues when you do not hava JAVA installed.
So remove start of emulator detection interval and allow it to be started from the API, when CLI is used as a library.
fix: stop executing avdmanager in case java is not available
In case JAVA_HOME is not set and there's no java executable in PATH, calls to
avdmanagerfail with error. However, on macOS this also leads to system prompt to install JAVA.To handle this, do not execute
avdmanagerin case there's no JAVA_HOME or java in PATH.PR Checklist
What is the current behavior?
What is the new behavior?
Fixes/Implements/Closes #[Issue Number].