Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Sidekick): debug operation fails on iOS when Developer Disk Image is not installed on device #4872

Merged
merged 1 commit into from
Jul 17, 2019

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented Jul 17, 2019

When ddi(Developer Disk Image) is not installed on iOS device and user tries to debug the application, the operation fails. This happens as the CLI doesn't emit userInteractionNeeded event as CLI doesn't provide the correct args to refreshApplicationWithoutDebug when refreshing the application in debug mode. The steps to reproduce are:

  1. Run on Device with iPhone without DDI
  2. Attach Debugger
  3. Make a change -> Debugger is detached, awaiting user to open the app on the device manually

PR Checklist

What is the current behavior?

What is the new behavior?

Fixes/Implements/Closes #[Issue Number].

@cla-bot cla-bot bot added the cla: yes label Jul 17, 2019
@rosen-vladimirov
Copy link
Contributor

test cli-device cli-debug cli-smoke package_version#rc

@rosen-vladimirov rosen-vladimirov added this to the 6.0.1 milestone Jul 17, 2019
@Fatme Fatme merged commit 9fb869e into release Jul 17, 2019
@Fatme Fatme deleted the fatme/fix-ddi-error branch July 17, 2019 19:09
@rosen-vladimirov rosen-vladimirov changed the title fix: fix the behavior when ddi is not installed on iOS device fix(Sidekick): debug operation fails on iOS when Developer Disk Image is not installed on deivce Jul 18, 2019
@rosen-vladimirov rosen-vladimirov changed the title fix(Sidekick): debug operation fails on iOS when Developer Disk Image is not installed on deivce fix(Sidekick): debug operation fails on iOS when Developer Disk Image is not installed on device Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants