Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass preserve-symlinks correctly #5015

Merged
merged 1 commit into from
Sep 10, 2019

Conversation

rosen-vladimirov
Copy link
Contributor

When runnign webpack, we want to pass --preserve-symlinks option to the Node.js. However, currently we pass it to webpack process itself. Fix the order of args.

PR Checklist

What is the current behavior?

CLI passes --preserve-symlinks to the webpack itself, not to the Node.js.

What is the new behavior?

CLI passes --preserve-symlinks to Node.js process which will run the webpack.

Fixes/Implements/Closes #[Issue Number].

When runnign webpack, we want to pass `--preserve-symlinks` option to the 	Node.js. However, currently we pass it to webpack process itself. Fix the order of args.
@rosen-vladimirov rosen-vladimirov added this to the 6.1.1 milestone Sep 10, 2019
@rosen-vladimirov rosen-vladimirov self-assigned this Sep 10, 2019
@cla-bot cla-bot bot added the cla: yes label Sep 10, 2019
@rosen-vladimirov
Copy link
Contributor Author

test cli-smoke cli-build

@rosen-vladimirov rosen-vladimirov merged commit aa8dc95 into release Sep 10, 2019
@rosen-vladimirov rosen-vladimirov deleted the vladimirov/fix-args-webpack branch September 10, 2019 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants