Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(logs): support sourcemaps from .map files #5434

Merged
merged 2 commits into from
Dec 29, 2020

Conversation

farfromrefug
Copy link
Contributor

PR Checklist

What is the current behavior?

What is the new behavior?

Fixes/Implements/Closes #[Issue Number].

@cla-bot cla-bot bot added the cla: yes label Nov 1, 2020
@rigor789 rigor789 added this to the 7.0.12 milestone Nov 2, 2020
@rigor789 rigor789 changed the title support reading sourcemaps from .map files feat(logs): support sourcemaps from .map files Nov 2, 2020
@rigor789
Copy link
Member

rigor789 commented Nov 2, 2020

@farfromrefug possible to add a test case in test/services/log-source-map-service.ts? Haven't looked extensively at it, but if needed we can create temp files like we do in some of the tests.

@farfromrefug
Copy link
Contributor Author

Sure can try. Going to take me a bit of time though.thanks

@farfromrefug
Copy link
Contributor Author

@rigor789 actually not that eady to create a test for this (doable though) because it depends on external files. Don't really have the time to do it :s sorry.
Could you test the change on your side and release?
Really needs this. And a consequence of that could be that all source maps could be external. Would be very practical on sims and also much faster!
Thanks

Copy link
Member

@rigor789 rigor789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added test cases now, LGTM

@rigor789 rigor789 merged commit de678cf into NativeScript:master Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants