Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: version command check update #5461

Merged
merged 2 commits into from
Jan 27, 2021
Merged

feat: version command check update #5461

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0c3f34
feat: version command check update
janoshrubos Jan 7, 2021
c73f26d
feat: show a spinner while fetching latest version
rigor789 Jan 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 37 additions & 10 deletions lib/common/dispatchers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,14 @@ import {
ICommandDispatcher,
ICancellationService,
ISysInfo,
IFileSystem,
IFutureDispatcher,
IQueue,
IErrors,
} from "./declarations";
import { IOptions } from "../declarations";
import { IOptions, IPackageManager, IVersionsService } from "../declarations";
import { IInjector } from "./definitions/yok";
import { injector } from "./yok";
import { PackageManagers } from "../constants";

export class CommandDispatcher implements ICommandDispatcher {
constructor(
Expand All @@ -25,7 +25,9 @@ export class CommandDispatcher implements ICommandDispatcher {
private $staticConfig: Config.IStaticConfig,
private $sysInfo: ISysInfo,
private $options: IOptions,
private $fs: IFileSystem
private $versionsService: IVersionsService,
private $packageManager: IPackageManager,
private $terminalSpinnerService: ITerminalSpinnerService
) {}

public async dispatchCommand(): Promise<void> {
Expand Down Expand Up @@ -99,14 +101,39 @@ export class CommandDispatcher implements ICommandDispatcher {
return "";
}

private printVersion(): void {
let version = this.$staticConfig.version;

const json = this.$fs.readJson(this.$staticConfig.pathToPackageJson);
if (json && json.buildVersion) {
version = `${version}-${json.buildVersion}`;
private async printVersion(): Promise<void> {
this.$logger.info(this.$staticConfig.version);

const spinner = this.$terminalSpinnerService.createSpinner();
spinner.start("Checking for updates...");
const nativescriptCliVersion = await this.$versionsService.getNativescriptCliVersion();
spinner.stop();

const packageManagerName = await this.$packageManager.getPackageManagerName();
let updateCommand = "";

switch (packageManagerName) {
case PackageManagers.npm:
updateCommand = "npm i -g nativescript";
break;
case PackageManagers.yarn:
updateCommand = "yarn global add nativescript";
break;
case PackageManagers.pnpm:
updateCommand = "pnpm i -g nativescript";
break;
}
if (
nativescriptCliVersion.currentVersion ===
nativescriptCliVersion.latestVersion
) {
// up-to-date
spinner.succeed("Up to date.");
} else {
spinner.info(
`New version of NativeScript CLI is available (${nativescriptCliVersion.latestVersion}), run '${updateCommand}' to update.`
);
}
this.$logger.info(version);
}
}
injector.register("commandDispatcher", CommandDispatcher);
Expand Down
2 changes: 1 addition & 1 deletion lib/options.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@ export class Options {
opts[this.getDashedOptionName(key)] = value;
});

const parsed = yargs(process.argv.slice(2)).help(false);
const parsed = yargs(process.argv.slice(2)).version(false).help(false);
this.initialArgv = parsed.argv;
this.argv = parsed.options(<any>opts).argv;

Expand Down