Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove duplicate plugins data #5563

Merged
merged 2 commits into from
Aug 23, 2021
Merged

remove duplicate plugins data #5563

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1088bd7
remove duplicate plugins data
farfromrefug Aug 19, 2021
6f2beca
chore: add comment & use arrow-function
rigor789 Aug 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 31 additions & 21 deletions lib/services/plugins-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,22 +283,27 @@ export class PluginsService implements IPluginsService {
_.keys(packageJsonContent.devDependencies)
);

const notInstalledDependencies = allDependencies.map(dep => {
try {
this.$logger.trace(`Checking if ${dep} is installed...`);
require.resolve(`${dep}/package.json`, {
paths: [projectData.projectDir]
})

// return false if the dependency is installed - we'll filter out boolean values
// and end up with an array of dep names that are not installed if we end up
// inside the catch block.
return false;
} catch(err) {
this.$logger.trace(`Error while checking if ${dep} is installed. Error is: `, err)
return dep;
}
}).filter(Boolean);
const notInstalledDependencies = allDependencies
.map((dep) => {
try {
this.$logger.trace(`Checking if ${dep} is installed...`);
require.resolve(`${dep}/package.json`, {
paths: [projectData.projectDir],
});

// return false if the dependency is installed - we'll filter out boolean values
// and end up with an array of dep names that are not installed if we end up
// inside the catch block.
return false;
} catch (err) {
this.$logger.trace(
`Error while checking if ${dep} is installed. Error is: `,
err
);
return dep;
}
})
.filter(Boolean);

if (this.$options.force || notInstalledDependencies.length) {
this.$logger.trace(
Expand Down Expand Up @@ -342,7 +347,8 @@ export class PluginsService implements IPluginsService {
dependencies =
dependencies ||
this.$nodeModulesDependenciesBuilder.getProductionDependencies(
projectData.projectDir, projectData.ignoredDependencies
projectData.projectDir,
projectData.ignoredDependencies
);

if (_.isEmpty(dependencies)) {
Expand All @@ -357,10 +363,14 @@ export class PluginsService implements IPluginsService {
projectData.projectDir,
platform
);
const pluginData = productionPlugins.map((plugin) =>
this.convertToPluginData(plugin, projectData.projectDir)
);
return pluginData;
return productionPlugins
.map((plugin) => this.convertToPluginData(plugin, projectData.projectDir))
.filter((item, idx, self) => {
// Filter out duplicates to speed up build times by not building the same dependency
// multiple times. One possible downside is that if there are different versions
// of the same native dependency only the first one in the array will be built
return self.findIndex((p) => p.name === item.name) === idx;
});
}

public getDependenciesFromPackageJson(
Expand Down