Add timeout option to debug command #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ |
| @@ -195,8 +196,8 @@ class AndroidDebugService implements IDebugService { | |||
| private startAndGetPort(packageName: string): IFuture<number> { | |||
| return (() => { | |||
| let port = -1; | |||
| let timeout = 60; | |||
|
|
|||
| let timeout = this.$utils.getParsedTimeout(60); | |||
There was a problem hiding this comment.
tab/space isssue maybe
|
👍 |
Fatme
force-pushed
the
fatme/debugger-timeout
branch
from
a5d32a1 to
06cefce
Compare
|
✅ |
| let timeout = timeoutInMilliseconds || this.$utils.getMilliSecondsTimeout(IOSDebugService.TIMEOUT_SECONDS); | ||
| let readyForAttachTimeout = timeout / 10 ; | ||
| let defaultReadyForAttachTimeout = 5000; | ||
| return readyForAttachTimeout > defaultReadyForAttachTimeout ? readyForAttachTimeout : defaultReadyForAttachTimeout; |
There was a problem hiding this comment.
You can use Math.max here
Fatme
force-pushed
the
fatme/debugger-timeout
branch
from
06cefce to
cd6209d
Compare
|
✅ |
Fatme
pushed a commit
that referenced
this pull request
Jul 29, 2015
Add timeout option to debug command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#682
#636
#375
Should be merged after this PR telerik/mobile-cli-lib#406