Skip to content
This repository has been archived by the owner on Aug 7, 2021. It is now read-only.

Commit

Permalink
feat(TypeScript): use ts-loader instead of `awesome-typescript-load…
Browse files Browse the repository at this point in the history
…er` (#738)

We executed some performance tests to compare `ts-loader` and `awesome-typescript-loader`. The difference in the build time between the two is insignificant. On the other hand, the `ts-loader` is 50% smaller than `awesome-typescript-loader` and is a dependency of the `nativescript-dev-webpack` package because it is needed in the {N}-Vue projects anyway.
  • Loading branch information
sis0k0 authored Dec 14, 2018
1 parent 9adc7e7 commit 7f67198
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 10 deletions.
12 changes: 8 additions & 4 deletions demo/TypeScriptApp/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,8 @@ module.exports = env => {
alias: {
'~': appFullPath
},
// don't resolve symlinks to symlinked modules
symlinks: false
// resolve symlinks to symlinked modules
symlinks: true
},
resolveLoader: {
// don't resolve symlinks to symlinked loaders
Expand Down Expand Up @@ -192,10 +192,14 @@ module.exports = env => {
{
test: /\.ts$/,
use: {
loader: "awesome-typescript-loader",
options: { configFileName: "tsconfig.tns.json" },
loader: "ts-loader",
options: {
configFile: "tsconfig.tns.json",
allowTsInNodeModules: true,
},
}
},

]
},
plugins: [
Expand Down
1 change: 0 additions & 1 deletion dependencyManager.js
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ function removeObsoleteDeps(packageJson) {
"uglifyjs-webpack-plugin",
"@angular-devkit/core",
"resolve-url-loader",
"awesome-typescript-loader",
"sass-loader",
];

Expand Down
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@
},
"dependencies": {
"@angular-devkit/core": "~7.1.0",
"awesome-typescript-loader": "~5.2.1",
"clean-webpack-plugin": "~1.0.0",
"copy-webpack-plugin": "~4.6.0",
"css-loader": "~1.0.0",
Expand Down
11 changes: 7 additions & 4 deletions templates/webpack.typescript.js
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,8 @@ module.exports = env => {
alias: {
'~': appFullPath
},
// don't resolve symlinks to symlinked modules
symlinks: false
// resolve symlinks to symlinked modules
symlinks: true
},
resolveLoader: {
// don't resolve symlinks to symlinked loaders
Expand Down Expand Up @@ -190,8 +190,11 @@ module.exports = env => {
{
test: /\.ts$/,
use: {
loader: "awesome-typescript-loader",
options: { configFileName: "tsconfig.tns.json" },
loader: "ts-loader",
options: {
configFile: "tsconfig.tns.json",
allowTsInNodeModules: true,
},
}
},
]
Expand Down

0 comments on commit 7f67198

Please sign in to comment.