This repository has been archived by the owner on Aug 7, 2021. It is now read-only.
fix: import the workaroundResolve funciton based on the Angular version (it was moved from compiler_host to utils in Angular 8) #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fatme
approved these changes
May 21, 2019
DimitarTachev
force-pushed
the
feature/angular8
branch
from
c3f7d80 to
eb69763
Compare
|
This PR is tested with: |
|
test --ignore api23 ios11 branch_ngapps#amiorkov/angular8-rc branch_nativescript_angular#amiorkov/angular8-rc |
…on (it was moved from compiler_host to utils in Angular 8)
DimitarTachev
force-pushed
the
feature/angular8
branch
from
eb69763 to
56224a8
Compare
|
test --ignore api23 ios11 branch_ngapps#amiorkov/angular8-rc branch_nativescript_angular#amiorkov/angular8-rc |
|
test --ignore api23 ios11 branch_ngapps#amiorkov/angular8-rc branch_nativescript_angular#amiorkov/angular8-rc |
|
test --ignore api23 ios11 branch_ngapps#amiorkov/angular8-rc branch_nativescript_angular#amiorkov/angular8-rc |
Fatme
approved these changes
May 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
A
workaroundResolve is not a functionerror is thrown with Angular 8 (@ngtools/webpack@8.0.0)What is the new behavior?
The Angular apps are properly built with Angular 8.
Related to: NativeScript/nativescript-angular#1833 NativeScript/nativescript-angular#1831