Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Python 3.9 #680

Closed
devernay opened this issue Oct 12, 2021 · 6 comments
Closed

Switch to Python 3.9 #680

devernay opened this issue Oct 12, 2021 · 6 comments
Labels
difficulty:medium Medium difficulty bug/issue

Comments

@devernay
Copy link
Member

If we can get Shiboken+PySide1 to compile for Python3.9, we're good!

Unfortunately, PySide does not officially support Python more recent than 3.4, see pyside/PySide#132

But MacPorts does it, and the patches are pretty simple:

We may also want to collect the Win-specific patches from there: krrr/PySide@1.2.4...1.2.4-1

What needs to be done:

  • apply patches when building on Windows, macOS, Linux
  • install PySide for python3 in a different place than PySide for python2 (ok on macOS, not ok on Linux where it is installed in the Qt dir, what about Windows?)
  • fix the installer scripts to pick the right PySide version
  • bump Natron version to 2.5 (since this may break some existing projects which use Python2 syntax)
@devernay devernay added the difficulty:medium Medium difficulty bug/issue label Oct 12, 2021
@rodlie
Copy link
Contributor

rodlie commented Oct 12, 2021

Sounds like a plan :)

I will also need to update everything Python3 related on Windows, I think I'm on 3.6 (didn't bother to upgrade since it's only used during the build process).

@devernay
Copy link
Member Author

devernay commented Oct 18, 2021

The branch https://github.com/NatronGitHub/Natron/tree/RB-2.4-python3support adds full python3 support (add CONFIG+=python3 to the qmake line), and I was able to compile and run the tests on macOS.
Next steps are:

  1. add shiboken-py3 and pyside-py3 to the linux SDK. See https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=python-pyside and https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=shiboken -> I'll do that DONE
  2. same on Windows (can you help @rodlie?)
  3. push this to RB-2.5 with RB-2.5: python3 support #686
  4. maybe push RB-2.5: use qtpy rather than pyside #687 too
  5. publish 2.5.0-alpha1, with python2 and python3 versions

@rodlie
Copy link
Contributor

rodlie commented Oct 18, 2021

same on Windows (can you help @rodlie?)

Already fixed shiboken(py2+py3), pyside will need to wait, currently I'm not able to build pyside at all. Might be related to my move to Windows 10, or something... (will find a fix).

EDIT: found the pyside issue, object path was set to 1024 max.

@devernay
Copy link
Member Author

@rodlie is the Windows SDK now containing py3 versions of shiboken/pyside? If yes, can you edit the comment above, and review #686 ?

@rodlie
Copy link
Contributor

rodlie commented Oct 25, 2021

Should work in theory, have not tested it yet. Was holding back until 2.4.1 was released (so I didn't mess up the build machine). Should have time to start testing today/tomorrow.

@devernay
Copy link
Member Author

devernay commented Nov 2, 2021

Released https://github.com/NatronGitHub/Natron/releases/tag/v2.5.0-alpha.1 which runs Python 3.9

@devernay devernay closed this as completed Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty:medium Medium difficulty bug/issue
Projects
None yet
Development

No branches or pull requests

2 participants