Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Feature): Command Palette #836

Closed
5 of 7 tasks
erayerdin opened this issue Sep 14, 2022 · 9 comments
Closed
5 of 7 tasks

(Feature): Command Palette #836

erayerdin opened this issue Sep 14, 2022 · 9 comments
Labels
type:feature New feature or request

Comments

@erayerdin
Copy link

erayerdin commented Sep 14, 2022

Make sure to follow our issue report guidelines

Provide a description of your feature request

Command palette is a feature that is widely adopted by code editors. This is how it is in VSCode. It is usually triggered by CTRL+SHIFT+P.

I think Natron would benefit so much from this, especially considering there are a lot of nodes, users could reach to what they want easily.

Is this a realistically implementable feature?

  • My feature is realistically implementable
  • My feature is NOT realistically implementable

Can you contribute in creating this feature?

  • I am unable, or not willing to contribute to creating this feature
  • I am able and willing to contribute to the creation of this feature

Additional details

No response

@erayerdin erayerdin added the type:feature New feature or request label Sep 14, 2022
@rodlie
Copy link
Contributor

rodlie commented Sep 15, 2022

Press the TAB key while the nodegraph has focus. Or do you want something else?

@erayerdin
Copy link
Author

Press the TAB key while the nodegraph has focus. Or do you want something else?

Wasn't aware this feature existed. I was trying to find every type of node navigating with my mouse.

Please, feel free to close.

@devernay
Copy link
Member

Not closing. We need to make this shortcut more visible.
Maybe an item in the right-click menu (and btw I don't think than "Find" deserves that place and that room in the right click menu, especially since the shortcut is so easy to remember)
image

@devernay
Copy link
Member

I think all items below "Edit" should be in a submenu called "View".
And right below that View menu there should be an item "Insert node" hinting at the shortcut "TAB"

@Shrinks99
Copy link
Contributor

Lots of these seem like menu bar items... Natron doesn't have a "View" menu but it probably should as you say. It does have a "Display" menu which is where project settings are located? I get the rationale behind this (Project settings are an actual window in Natron) but that should probably be moved to "File" to better match other UI conventions with "Display" becoming "View" and moving many of the right click menu options there?

Agreed about putting "Create Node" with the shortcut displayed in the right click menu. Could also double it up in the menu bar which nobody will ever use but it will serve to direct people to the command field.

Screen Shot 2022-10-14 at 2 48 52 PM

@devernay
Copy link
Member

Most of these can't be in the menubar, because these shortcuts are specific to when the nodegraph has focus. A menubar that would change with focus would be very unusual, and probably not following most UI guidelines: this usually happens only when switching between applications

@Shrinks99
Copy link
Contributor

Shrinks99 commented Oct 14, 2022

+1, Menu bars shouldn't change with focus of in-application windows. Some apps (Maya) change the menu bar out depending on what view a user is in, I hate this and it adds complexity.

I don't think "Show expressions links", "auto-hide optional inputs", "Display Cache Memory Consumption" and the like are focus-related despite the fact that they only pertain to a certain window? Those seem more like global view options to me rather than context menu actions as they don't actually perform an action within the node graph, they only change how information is conveyed to users. Items like "center on all nodes" and "Find" are good to keep in the context menu as these actions are accessed far more frequently and are dependent on the user currently operating the window.

Adding a separator in the menu bar "View" section to signify that these items are node-graph specific could be helpful.

@devernay
Copy link
Member

Here's the new right-click nodegraph menu:

  • the "tab" shortcut is more obvious
  • all non-edit items were put in the "View" submenu
  • I have no time to check if things can move to the global menubar, which may be complicated anyway

Does that look ok?
image

devernay added a commit that referenced this issue Oct 14, 2022
@devernay
Copy link
Member

fixed in 89bfde7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants