Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes spelling errors #761

Merged
merged 3 commits into from
Feb 1, 2022
Merged

Conversation

Shrinks99
Copy link
Contributor

@Shrinks99 Shrinks99 commented Jan 26, 2022

PR Description

**What type of PR is this? **

  • Bug fix (non-breaking change which fixes an issue)
  • My change requires a change to the documentation
    • I have updated the documentation accordingly

What does this pull request do?

Fixes spelling errors flagged in #759 This also updates CHANGELOG.md retroactively, I did that as a separate commit so it's easier to revert if need be but IMO should be kept in.

Have you tested your changes (if applicable)? If so, how?

NA (I hope... This type of change is pretty minor and I am confident that it won't result in anything bad)

Futher details of this pull request

These spelling fixes do not change anything in /libs, @alexmyczko you may still find that errors come up, but hopefully all the issues within Natron's actual code are resolved!

There are some text editor white space removals. Annoying to review but probably for the best? :\

I probably shouldn't have fixed errors in tools/MINGW-packages/mingw-w64-zlib/06-add-64bit-functions-and-fix-typos.patch... can revert that. Fixed in 5b09f75

- Does not change anything in libs
- Some text editor auto whitespace removals
- Small improvement to the merge node description
- minor gramatical fixes
@rodlie
Copy link
Contributor

rodlie commented Jan 26, 2022

I probably shouldn't have fixed errors in tools/MINGW-packages/mingw-w64-zlib/06-add-64bit-functions-and-fix-typos.patch... can revert that.

Yeah, do not modify patches.

@Shrinks99
Copy link
Contributor Author

Yeah, do not modify patches.

Reverted.

@devernay devernay merged commit 69d3907 into NatronGitHub:RB-2.5 Feb 1, 2022
@Shrinks99 Shrinks99 deleted the spelling-fixes branch February 1, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants