Substitute QGL classes with QOpenGL #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YakoYakoYokuYoku
added a commit
that referenced
this pull request
Jan 30, 2022
YakoYakoYokuYoku
added a commit
that referenced
this pull request
Jan 30, 2022
YakoYakoYokuYoku
force-pushed
the
qopengl-instead-of-qgl
branch
from
e911ce0 to
76e631b
Compare
YakoYakoYokuYoku
added a commit
that referenced
this pull request
Jan 31, 2022
YakoYakoYokuYoku
force-pushed
the
qopengl-instead-of-qgl
branch
from
76e631b to
30c7095
Compare
YakoYakoYokuYoku
added a commit
that referenced
this pull request
Jan 31, 2022
YakoYakoYokuYoku
force-pushed
the
qopengl-instead-of-qgl
branch
from
30c7095 to
f0818c6
Compare
|
Did you test the Qt4 build as well? |
|
Yes, although it was only on a Linux box but I think it'll do fine on the other OSes. |
1 task
devernay
requested changes
Feb 1, 2022
|
I'll take some time to test on macOS (Qt4 and Qt5). Sorry if it causes some delay |
YakoYakoYokuYoku
force-pushed
the
qopengl-instead-of-qgl
branch
from
d436c17 to
ccb937e
Compare
No problem with it and thanks for taking the time to test it. |
|
@devernay how's testing going? As this is a blocker for some local work, although no problem if testing should take even more time. |
|
good! |
devernay
approved these changes
Feb 18, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
What type of PR is this? (Check one of the boxes below)
What does this pull request do?
Given that the Qt OpenGL module was deprecated in Qt 5.4.0, removed in Qt 6 and most importantly was not functioning under a Wayland session (e.g. alpha output in KDE KWin or corrupted images in Sway), I've replaced its usage with the newer OpenGL integration from Qt Gui and used both type definitions plus preprocessor conditionals for backwards compatibility with Qt 4.
Show a few screenshots (if this is a visual change)
Have you tested your changes (if applicable)? If so, how?
By building Natron and using the viewer, the dope sheet editor, the curve editor and the histogram.
Futher details of this pull request
Will post support for Wayland offscreen (
OSGLContext) soon.