Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mipmapLevel capitalization and a few minor mipmapLevel related cleanups #922

Merged
merged 4 commits into from
Sep 13, 2023

Conversation

acolwell
Copy link
Collaborator

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:

PR Description

What type of PR is this? (Check one of the boxes below)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality nor fixes a bug but improves Natron in some way)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My change requires a change to the documentation
    • I have updated the documentation accordingly

What does this pull request do?

The bulk of this change is making the capitalization consistent for mipmap. There was a mix of mipMap and mipmap. Now everything except for a serialization field name uses the mipmap form.

I've also included a few other mipmap code related things that I came across while renaming.

  • Replaced a few cases where mipmapLevels were declared as ints instead of unsigned ints.
  • Removed a method that had an identical implementation as another similarly named method in ViewerInstance.
  • Renamed OverlaySupport::getCurrentRenderScale() to getCurrentMipmapLevel() as discussed in a previous pull request.

Have you tested your changes (if applicable)? If so, how?

Yes. I've verified that the code builds and all the unit tests still pass. There really aren't any major changes. Most of the int -> unsigned int changes happened around the proxy level selection code so I made sure that worked as expected on a few projects. Other than that there isn't really anything else to test other than making sure the code compiled.

@acolwell acolwell changed the title Fix mipmaplevel case Fix mipmapLevel capitalization and a few minor mipmapLevel related cleanups Sep 12, 2023
@devernay devernay self-requested a review September 13, 2023 17:43
Copy link
Member

@devernay devernay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! LGTM!

@acolwell acolwell merged commit 0b03e24 into NatronGitHub:RB-2.5 Sep 13, 2023
@acolwell acolwell deleted the fix_mipmaplevel_case branch September 13, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants