Fix Windows build failure caused by missing dependency. #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Msys2's libcurl package was recently updated to enable HTTP/3 support which means it now also depends on libnghttp3. genDllVersions.sh was updated to include this new dependency. The Windows installer build action was also changed to upload its build artifacts before it tests to make sure the plugins load. This makes it possible to look at the generated artifacts for missing dependencies if the plugin load verification fails.
devernay
approved these changes
May 30, 2024
I'm not sure what they are used for either. The GMIC plugin depends on libcurl, which appears to depend on nghttp2 and nghttp3. I haven't really dug into why libcurl needs these libraries. |
acolwell
added a commit
to acolwell/Natron
that referenced
this pull request
Jul 2, 2024
…#969) Msys2's libcurl package was recently updated to enable HTTP/3 support which means it now also depends on libnghttp3. genDllVersions.sh was updated to include this new dependency. The Windows installer build action was also changed to upload its build artifacts before it tests to make sure the plugins load. This makes it possible to look at the generated artifacts for missing dependencies if the plugin load verification fails.
acolwell
added a commit
that referenced
this pull request
Jul 2, 2024
Msys2's libcurl package was recently updated to enable HTTP/3 support which means it now also depends on libnghttp3. genDllVersions.sh was updated to include this new dependency. The Windows installer build action was also changed to upload its build artifacts before it tests to make sure the plugins load. This makes it possible to look at the generated artifacts for missing dependencies if the plugin load verification fails.
devernay
added a commit
that referenced
this pull request
Jul 23, 2024
* Update README to reflect 2.5 release * Remove Bountysource from Readme Bountysource appears to be dead, so it should be removed * macports update * Update README.md * update MacPorts * Update compiler-common.sh * Debug build fix * CMake: Debug build type fix * Comment out check for debug flag build type. (#972) * Fix windows pacman repo build. (#968) Msys2 updated gcc in the last few days which has caused the package repo build to fail. Here are some minor fixes to make the build work again. - Add fmt to openimageio's dependency list since the version included with the openimageio source now appears to cause an internal compiler error. - Added an include for math.h to in a libsox test file to make the compiler stop generating an error about fabs() not being defined. - Fix type mismatch and missing declaration errors in ImageMagick. - Updated mingw-w64-dump_syms gitcommit to point to a version that fixes a missing header build error. * Fix Windows build failure caused by missing dependency. (#969) Msys2's libcurl package was recently updated to enable HTTP/3 support which means it now also depends on libnghttp3. genDllVersions.sh was updated to include this new dependency. The Windows installer build action was also changed to upload its build artifacts before it tests to make sure the plugins load. This makes it possible to look at the generated artifacts for missing dependencies if the plugin load verification fails. * Fix Windows debug cmake build. (#973) - Force Shiboken to use detected python libraries instead of using its own library detection logic. - Specify -O compiler option for debug builds like the qmake build. - Remove unconditional NDEBUG define added by the Shiboken cmake helper so that asserts work correctly on debug builds. * Add logic to capture/restore existing GL context. This fixes asserts in debug builds where Qt's GL context is set when a ScopedGLContext is created. This can happen when we have a project open and the user tries to open another project. When the event callback is dispatched, the Qt GL context is still set. The fix justs removes the assert and adds logic to save and restore any existing GL context that is set. * MacPorts update * Fix rotopaint overlay 2.5 (#986) * RotoPaint: always draw the overlay when the tool is part of the overlay * tools/MacPorts: remove .rej files --------- Co-authored-by: Marcel Ruegenberg <gh2@picodesign.de> Co-authored-by: Frédéric Devernay <devernay@users.noreply.github.com> Co-authored-by: kafxa <148536772+kafxa@users.noreply.github.com> Co-authored-by: Aaron Colwell <300262+acolwell@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:
PR Description
What type of PR is this? (Check one of the boxes below)
What does this pull request do?
Msys2's libcurl package was recently updated to enable HTTP/3 support which means it now also depends on libnghttp3. genDllVersions.sh was updated to include this new dependency.
The Windows installer build action was also changed to upload its build artifacts before it tests to make sure the plugins load. This makes it possible to look at the generated artifacts for missing dependencies if the plugin load verification fails.
Have you tested your changes (if applicable)? If so, how?
Yes. The build installer action works again and the plugin load verification step now passes on GMIC plugin again. Before this change the GMIC plugin was causing the plugin load verification step to fail because of the missing dependency.