feat(ui): opt in admin touch toggling #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonwellsjo
changed the title
|
Example of enabling touch triggering
video1316524636.mp4 |
There was a problem hiding this comment.
Let's discuss in Slack.
I don't like that it incurs the tax of listening of every touchstart of every user on every page, forever. Imagine the impact of this on the environment? Electricity burned?
Previously it only listened to keydown, which happens on average 0 times for an average mobile user, that's why it was "ok".
|
Not going this direction because of "cost of listening to everything" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.