Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerized version #179

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

francozacco
Copy link

Purpose / Goal

Added docker files to run the server on a docker container. I also added documentation explaining how to run the docker container.

Type

Please mention the type of PR

  • Bug Fix
  • Refactoring / Technology upgrade
  • New Feature
  • Documentation
  • Other : | Please Specify |

@amitguptagwl
Copy link
Member

Thanks for your effort. But I'm wondering if the end-user is not aware of git. If he is using docker then probably docker pull imglab would be better option.

@francozacco
Copy link
Author

francozacco commented Jun 12, 2020 via email

@amitguptagwl
Copy link
Member

I appreciate your work. But we can't link any 3rd party code right now due to security reasons. But I'll think about it. However, now I'm thinking about its need. Currently, people just need to open it in their browsers once and it perfectly works offline. So no load on their system and no technical knowledge is required.

I feel we should focus more on the required features than good to have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants