Follow up of pull request #626 (#627)

* Fix ReDoS in dice_coefficient Fix ReDos in `dice_coefficient.js` This related issue addresses #613 * Repaired a test for Dice coefficient Co-authored-by: Yeting Li <liyt@ios.ac.cn>
NaturalNode · Nov 11, 2021 · 90e85af · 90e85af
1 parent 7689c9a
commit 90e85af
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/natural/distance/dice_coefficient.js b/lib/natural/distance/dice_coefficient.js
@@ -51,7 +51,7 @@ function intersect (set1, set2) {
 function sanitize (str) {
   // Turn characters to lower string, remove space at the beginning and end,
   // replace multiple spaces in the middle by single spaces
-  return str.toLowerCase().replace(/^\s+|\s+$/g, '').replace(/s+/g, ' ')
+  return str.toLowerCase().replace(/\s+/g, ' ').replace(/^\s+|\s+$/g, '')
 }
 
 function diceCoefficient (str1, str2) {

diff --git a/spec/dice_coefficient_spec.js b/spec/dice_coefficient_spec.js
@@ -32,6 +32,6 @@ describe('dice', function () {
   it('should compare complete texts', function () {
     const text1 = require('./test_data/Wikipedia_EN_FrenchRevolution.json').text
     const text2 = require('./test_data/Wikipedia_EN_InfluenceOfTheFrenchRevolution.json').text
-    expect(dice(text1, text2)).toBe(0.7897503285151117)
+    expect(dice(text1, text2)).toBe(0.7939374395356337)
   })
 })