Remove must from go-clr.go #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm tagging you, @Ne0nd0g, to bring this PR to your attention. Thanks a ton for improving so much upon the original repo! I'm quite excited about using this package and will probably want to push some more improvements as I start using it and learn more about it. |
|
@mec07 Really appreciate the PR and I agree we should be returning errors instead of exiting. I'll work on getting this merged in soon. |
Thanks! 😄 I've tweeted you a question 😅 . Hopefully it's clear. Twitter isn't the best way to ask detailed questions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We really must remove
must(err)error handling fromgo-clr.gobecause it can cause your entire program to bomb out without even the slightest chance of recovery. It makes this library incredibly unstable. If it goes wrong it should return an error, notlog.Fatal(err).log.Fataldoesn't even allow defer statements to run! It's really bad.I'm leaving it in the
examplesfolder though as it doesn't cause any direct issues there.Note: I've forked off your fork and I'm creating this PR for to it because I can see that you've made quite a few improvements upon the original repo. Thanks for taking the original and improving it so much!