Delete temp files immediately after use

NeRdTheNed · Aug 9, 2023 · e9c4a9e · e9c4a9e
1 parent 2ce7db6
commit e9c4a9e
Showing 1 changed file with 11 additions and 2 deletions.
diff --git a/JarTighten-lib/src/main/java/io/github/NeRdTheNed/JarTighten/JarTighten.java b/JarTighten-lib/src/main/java/io/github/NeRdTheNed/JarTighten/JarTighten.java
@@ -733,8 +733,17 @@ public boolean optimiseJar(Path input, Path output, boolean overwrite) throws IO
             returnVal = optimiseJar(archive, outputStream);
         }
 
-        if (returnVal && handleSame) {
-            Files.copy(possibleTempPath, output, StandardCopyOption.REPLACE_EXISTING);
+        if (handleSame) {
+            if (returnVal) {
+                Files.copy(possibleTempPath, output, StandardCopyOption.REPLACE_EXISTING);
+            }
+
+            try {
+                Files.deleteIfExists(possibleTempPath);
+            } catch (final Exception e) {
+                System.err.println("Issue deleting temporary file " + possibleTempPath);
+                e.printStackTrace();
+            }
         }
 
         return returnVal;