Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove description in PathLinkInSequenceGroup #785

Closed

Conversation

ue71603
Copy link
Contributor

@ue71603 ue71603 commented Sep 30, 2024

would be duplicated otherwise

would be duplicated otherwise
@ue71603 ue71603 added the bug Technical mistake, inconsistency with the documentation, etc. label Sep 30, 2024
@ue71603 ue71603 added this to the netex_1.2 milestone Sep 30, 2024
@ue71603
Copy link
Contributor Author

ue71603 commented Sep 30, 2024

@skinkie for this not possible as description was used. close?

@skinkie
Copy link
Contributor

skinkie commented Sep 30, 2024

@skinkie for this not possible as description was used. close?

What you mean in this case with 'used'? Are there two descriptions used at the same place?

@ue71603
Copy link
Contributor Author

ue71603 commented Sep 30, 2024

Hi Stefan
Removing it in master resultated in many invalid examples (see ci /run). So there is no other one (or at least it is not at exactly the same place).

@ue71603
Copy link
Contributor Author

ue71603 commented Sep 30, 2024

The problem is, that the Description now would need to be before the PathLinkRef

it was

  • Description
  • PathLinkRef
  • Description

So the position of the Description would need to be changed in all examples.

image

@skinkie
Copy link
Contributor

skinkie commented Sep 30, 2024

The suggestion was to remove it from next.

@ue71603
Copy link
Contributor Author

ue71603 commented Sep 30, 2024

no, was not: you referenced master in #748

@skinkie
Copy link
Contributor

skinkie commented Sep 30, 2024

I am happy to update all the examples. But I wonder who uncarefully duplicated, provided the wrong examples (and caused this mess).

@skinkie
Copy link
Contributor

skinkie commented Sep 30, 2024

no, was not: you referenced master in #748

In Next the same would go for PathLinkInSequenceGroup, removing the extra Description resolves the issue.

@ue71603
Copy link
Contributor Author

ue71603 commented Sep 30, 2024

I move the PR to next and update the examples.

@ue71603 ue71603 closed this Oct 1, 2024
@skinkie skinkie deleted the remove_description_path_link_in_sequence_group branch November 19, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Technical mistake, inconsistency with the documentation, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants