Independent build #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpetersson
reviewed
Oct 14, 2021
|
Looks reasonable to me structure wise. |
marvinmarnold
force-pushed
the
marvinmarnold/independent-build
branch
from
1439843 to
be291b9
Compare
marvinmarnold
force-pushed
the
marvinmarnold/independent-build
branch
from
be291b9 to
83fd72d
Compare
shawaj
reviewed
Oct 20, 2021
shawaj
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The hm-pktfwd build process is confusing. This is one of two proposals on how to structure the Dockerfile in order to improve things.
How
This proposal builds each library and then references one from the other. This proposal is most correct in that it cleanly separates each build process. The downside is that it requires more cognitive load to connect the build stages together across different repos.
The other proposal builds everything all at once in hm-pktfwd.
References