This repository has been archived by the owner on Nov 2, 2018. It is now read-only.
use local shortcuts for dev tools and plugins #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
worth reading the discussion of this approach here: electron/electron#1334 (comment) |
|
@lukechampine do you recommend that we not merge this PR then? |
|
It should be merged as long as it doesn't do anything wonky. Seems ok though. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents the UI's shortcuts (Ctrl-Shift-L and Ctrl-Shift-P) from being persistently registered even when the UI is not focused. We still want to preserve the semantics of the
globalShortcutapi, namely parsingCtrl+Shfit+xtype shortcut values and being able to receive shortcut events regardless of what DOM element is focused, so this code simply unregisters shortcuts when focus is lost and re-registers them when focus is regained, instead of using the JSwindow.onkeydown/keyupapi.Fixes #499.