This repository has been archived by the owner on Jul 7, 2021. It is now read-only.
Add integration tests and example to readme #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 19, 2020 16:34
mrcnski
force-pushed
the
readme-example
branch
2 times, most recently
from
9ab1c2b
to
f2c3900
Compare
mrcnski
changed the title
mrcnski
force-pushed
the
readme-example
branch
2 times, most recently
from
c13be5d
to
77d61bf
Compare
marcinja
reviewed
Jun 26, 2020
There was a problem hiding this comment.
Looks good to me. Tested locally with virtualenv
One thought for a follow-up: I'm not sure if the portals support this but siad has a dryrun flag so you don't have to actually upload to a portal while testing. This should be added as a param somewhere in the library and used in testing.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.