Fix bugs with ball logic to use proper pokeball type #1495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging latest
Merging latest
|
Some of these bugs got already fixed, please merge or resubmit the pr. |
ghost
closed this
ghost
reopened this
|
This is ready to go now. |
ghost
merged commit 
schnapster
pushed a commit
to schnapster/NecroBot
that referenced
this pull request
Dec 8, 2016
…er_ball_decision Fix bugs with ball logic to use proper pokeball type
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were numerous issues with the ball logic code, which have now been resolved. The configuration file also has pokeball-type catch probabilities now, so if you only want to use great balls on 20% and ultras on 10%, you can do that. Defaults are set to as they were hardcoded previously.