Add new option 'AlwaysEvolveWithLuckyEggWhenMinPokemonAmountOccurs' w… #2031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hich will use a lucky egg and evolve when criteria is met and KeepPokemonsThatCanEvolve is true
recon88
changed the title
|
Please pull in master and fix the conflict, then resubmit the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted a way to use the nice logic for KeepPokemonsThatCanEvolve = true and use a lucky egg when the UseLuckyEggsMinPokemonAmount criteria was met.
I therefore introduced a variable called 'AlwaysEvolveWithLuckyEggWhenMinPokemonAmountOccurs' which can be used together with KeepPokemonsThatCanEvolve = true.
We should maybe discuss what we want to do here if you dont like my idea. I think that KeepPokemonsThatCanEvolve is good but i wanted to use it to not transfer pokemonts and only use a lucky egg when UseLuckyEggsMinPokemonAmount was met.
Any input?