Refactor Execute() in CatchPokemonTasks.cs to fix 3 bugs with catching incense Pokemon. #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ching lured pokemon described in PR NecronomiconCoding#778.
|
What happened to lured pokemons working as intended? :) |
Ilses
changed the title
|
Oops, I meant incense. Although they're technically lured, that was unclear -- sorry about that! |
|
argh, thought about it while writing the incense code xD Thank you for finding this issue ;) Sadly, we still have to wait for AeonLucid/POGOProtos#81 . If this didn't get merged encounter_id for incense pkm will always be 0 ... |
|
Note: Used in PR #946, which resolves conflicts. |
|
thanks fix conflicts and reopen |
Closed
jjskuld
pushed a commit
to jjskuld/NecroBot
that referenced
this pull request
Sep 3, 2016
Minor addition to merged PR#809
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes PR #778 where the bugs are described. I have confirmed this refactor works when catching regular, incense, and lured Pokemon.