Egg incubation checks during PokeStop farming, and logging for hatch-events

[patrikwlund]

Edit: See new comment below

Still doesn't log hatch-events though, since ctx.Client.Inventory.GetHatchedEgg(); doesn't seem to return anything. Perhaps because the inventory (which includes pokemon) has already been refreshed?

[patrikwlund]

Since this PR hasn't been merged yet, I added additional functionality to it.

We now have hatch events for eggs. However, they are not based not actual hatch events from the server, because those turn up empty (for whatever reason). Instead, the client now remembers what the incubators stored previously and checks if there's a non-egg pokemon with that ID now (=hatched).

The incubator state is stored in: /bin/Temp/Incubators.json and doesn't require any kind of manual setup.

Not a very good solution, but it works.

[patrikwlund]

Since no one else has tested this yet:

I've had this running since I pushed it. Here's a screenshot of me hatching a zubat in-between pokestops. This covers both the frequency-commit and the hatching-commit. Would still be good if someone other than me tried it out though.

[Ilses]

I suspect this will break with multiple profiles.

[5andr0]

Good find @ Ilses
You can use it like that:

        private static string IncubatorUsagePath;

        public static async Task Execute(Context ctx, StateMachine machine)
        {
                IncubatorUsagePath = Path.Combine(ctx.LogicSettings.ProfilePath, "Temp", "Incubators.json");

                string folder = Path.GetDirectoryName(IncubatorUsagePath);
                if (!Directory.Exists(folder))
                {
                        Directory.CreateDirectory(folder);
                }

You can also use the already existing Logs directory instead of Temp. Otherwise you would have to check for its existence and create it

[Ilses]

I think I'd rather see:

private static readonly string IncubatorUsageFile = settings.ConfigPath + Path.DirectorySeparatorChar + "incubators.json"

...since the variable is a file, and not a path.

[patrikwlund]

Since it's neither a config nor a log, I think "Temp" fits better. It's not something you should include in your config backups.

[Ilses]

Fair enough. I'd still like the var renamed, but now I'm just picking nits ;)
I'll try it out pretty soon and let you know how it works.

[patrikwlund]

Made a commit for ProfilePath now. Also changed variable name to "...FilePath". A good compromise :)

[bjornegrim]

using this with no issues, merged myself with the latests commit, good work!

[Pakobbix]

can confirm.. it's pretty awesome to really hatch them while the bot runs and knowing the pokemon you got in your egg..

[5andr0]

Ready to merge, thanks for the profile path integration. Good work