Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat codebase to be more consistent with the style used in ImGui #95

Merged
merged 11 commits into from
Apr 7, 2021

Conversation

Nelarius
Copy link
Owner

@Nelarius Nelarius commented Apr 5, 2021

This codebase grew out of a different project of mine and, unfortunately, I didn't fully transform it to conform to ImGui's style at an early stage -- so to this day, an entirely different coding style is used internally. I figured a full transformation all at once would hurt a little less than frequent incremental changes, so this pr includes some changes to imnodes.h as well. As a result, the code should be a bit easier to integrate with C.

So just a heads up @sonoro1234 and @hoffstadt that this change is incoming since this might affect your imnodes integration work 👀

  • all internal functions to CamelCase
  • all members, internal and external, to CamelCase
  • static constants to UPPER_CASE
  • struct and enum definitions moved out of the imnodes namespace and prefixed with ImNodes
  • enum constants prefixed with ImNodes
  • namespace to CamelCase: ImNodes
  • update imnodes.h comments
  • update README.md

@hoffstadt
Copy link

Thanks for the heads up! And we appreciate your work on this.

@Nelarius Nelarius merged commit 36fa6a3 into master Apr 7, 2021
@Nelarius Nelarius deleted the clang-tidy-formatting branch April 7, 2021 07:13
@sonoro1234
Copy link
Contributor

Sorry for not realizing this earlier: namespace ImNodes will collide with https://github.com/rokups/ImNodes/blob/02b085dace8bdd815374d6440efb1f70d8a9ebaf/ImNodes.h#L35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants