Add generic methods for transpose and transpose!
#1937
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1937 +/- ##
==========================================
- Coverage 88.21% 88.20% -0.01%
==========================================
Files 119 119
Lines 30384 30394 +10
==========================================
+ Hits 26803 26809 +6
- Misses 3581 3585 +4 ☔ View full report in Codecov by Sentry. |
fingolfin
force-pushed
the
mh/transpose
branch
from
58c57fb to
ca700e0
Compare
| return x | ||
| end | ||
| # we have no generic way to change the dimensions of x, so instead we | ||
| # delegate to the two argument version of transpose! |
There was a problem hiding this comment.
Tests fails because in Nemo some transpose! methods with just one argument only work on square matrices.
Perhaps that the right decision, and I should match it here, and just throw an error in that case, too? Perhaps a bit more helpful one, but an error nevertheless.
Or perhaps the Nemo methods should be made more general.
Any thoughts on this, anyone?
There was a problem hiding this comment.
I never missed it for non-square matrices, but maybe @fieker has opinion/wishes?
There was a problem hiding this comment.
if it was missing - how can there be a test for it? I never used inplace transpose on non-square matrices. i do understand that this is possible (in flint) and an interesting research problem....
No description provided.