refactor: evaluate/subst for univariate polynomials #1948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1948 +/- ##
==========================================
+ Coverage 88.21% 88.22% +0.01%
==========================================
Files 119 119
Lines 30385 30429 +44
==========================================
+ Hits 26803 26845 +42
- Misses 3582 3584 +2 ☔ View full report in Codecov by Sentry. |
fingolfin
reviewed
Dec 25, 2024
thofma
commented
Dec 26, 2024
- rename `subst` to `evaluate_brent_kung` and add a hard alias for backwards compatibility - introduce `evaluate_horner` - use in-place operations where possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
substtoevaluate_brent_kungand add a hard aliasfor backwards compatibility
evaluate_horner(Ideally we can phase out
subst.)