Override resolve_resource_file to handle neon-core package resources
#249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeonDaniel
added a commit
to NeonDaniel/NeonCore
that referenced
this pull request
Jun 7, 2022
* Update Dependencies and Automated Testing (NeonGeckoCom#114) * Fix typo in audio test case * Troubleshooting test errors * Add neon-utils to requirements.txt Update setup scripts to reference current branch, not default * Fix test case to reference neon plugin * Update tts module name from ovos to neon in setup.sh * Patch osm search errors by bypassing osm when URL is provided (NeonGeckoCom#116) * Prevent spawning multiple instances of Neon (NeonGeckoCom#115) * Catch run_log errors in run_neon.py Update run_neon.py to kill any leftover processes * Increment core version * Override load_priority to utilize Neon config (NeonGeckoCom#120) * Pi Support (NeonGeckoCom#117) * Handle ARM unsupported local STT/TTS * Add some Pi-specific setup steps * Prevent creating start/stop shell scripts on Pi * Add pi dependencies and update setup.py * Update dependencies * Remove wait for internet connection in skills module init * Add python 3.7 test for Pi support Update default pi STT dependency * Troubleshooting dependency resolution * Update pi dependencies * Fix dependency specs in pi.txt * Rollback internet connection troubleshooting change * Add patched MycroftSkill with config changes imported from neon_utils (NeonGeckoCom#122) * Add patched MycroftSkill with config changes imported from neon_utils * Bump neon_utils dependency version * Add top-level mycroft.MycroftSkill override * Idle Screen initial implementation (NeonGeckoCom#121) * Idle Screen initial implementation * Relocate gui to new module Update setup.py entry points Cleanup resting screen implementation * Cleanup and resolve warnings * Simplify resting_screen.py code * Handle passed MessageBusClient Add skill_id to RestingScreen * Fix typo in neon_gui_service entrypoint (NeonGeckoCom#124) * Lock ovos-plugin-manager version (NeonGeckoCom#125) * Update dependency references (NeonGeckoCom#123) * Update requirements.txt to reference PyPI * Update requirements.txt version specs for current PyPI versions * Update 'jarbas' plugins to 'ovos' Update test requirements * Fix typos in ww plugin specs * Resolve Installation Errors (NeonGeckoCom#129) * Depreciate test_requirements.txt Update core_tests.yml requirements installation * Update test dependencies * Spec stricter dependencies * Unlock module dependency versions * Add constraints and reference in setup scripts * fix conflicting constraints * Add more constrants * Add more constraints * Add more constraints * Add more constraints * Add more constraints * Add more constraints * Add more constraints * Add more constraints * Add more constraints * Add more constraints * Add more constraints * Add more constraints * Add more constraints * Add more constraints * Add more constraints Fix typo in constraints.txt * Add more constraints * Resolve constraint conflicts * Update constraint versions * Update constraint versions * Update constraint versions * Update constraint versions based on dev environment * Set constraints.txt to match dev pip env * Fix constraints.txt URL specs from pip freeze * Remove neon core modules from constraints.txt * Update conflicting mock versions * Remove STT/TTS plugin constraints (repo refs) * Remove old google_cloud_speech version constraint * Update requirements installation to use legacy resolver * Revert dependency changes to troubleshoot test failures * Revert legacy resolver call * Replace legacy-resolver call Lock mycroft-messagebus-client version Replace updated module dependency definitions * Troubleshooting dependency conflicts * Remove constraints.txt * Loosen OPM requirement Prevent killing test_run_neon in run_neon Use ready events for testing modules * Revert OPM requirement for GH testing errors * Troubleshoot skills module test failure * Update TTS plugin reference to PyPI Add version specs to Neon core modules * Add libsndfile1 to apt dependency installation (NeonGeckoCom#127) * Update STT and TTS plugins to install from PyPI (NeonGeckoCom#133) * Update STT and TTS plugins to install from PyPI * Loosen OPM dependency spec * get ovos_utils alpha release for OPM compat * lock OPM version to troubleshoot Speech failures revert ovos_utils beta spec * bump neon_audio version spec * Loosen OPM to 0.0.1 * Update STT plugin versions to support newer OPM version * Troubleshoot dependency version conflicts * Bump deepspeech plugin version spec * Bump plugin specs to release versions * loosen ovos_utils to install stable version by default * Fix dependency versions (NeonGeckoCom#134) * fix ovos_utils spec to find a valid version * patch ovos_utils version * Update local install testing to only test python 3.8 * Update skill unit tests (NeonGeckoCom#135) * Update skill install tests to reflect correct/expected directory structure * Patch skill foldername after installation * Remove skill uid patch in skill_utils.py * Revert unused imports * Update translator to use neon_lang_config (NeonGeckoCom#126) * Update translator to use neon_lang_config to match detector Update translator defaults to valid neon plugins * Update default language modules add test_language.py unit tests * Add unit tests for get_language_dir Add language unit tests to GH automation * Add resources to upload res dirs Add language plugin to test.txt Add `en-au` test case to test_language.py * Make translation test case insensitive * Update language tests to use a dict of expected language resolutions * Refactor skills module config and online checks (NeonGeckoCom#137) * Refactor skills/__main__.py Implement network check from neon_utils (0.8.1a1) Make online check optional (HolmesV compatible config) NeonGeckoCom#136 * revert SkillManager import to troubleshoot test failures * Remove unused SkillManager import in __main__.py * Update neon_utils spec to stable version * Add missing libretranslate local dependency (NeonGeckoCom#142) * refactor/rework_service_launchers (NeonGeckoCom#141) wrap __main__py logic into helper classes for more flexibility Co-authored-by: jarbasal <jarbasai@mailfence.com> * Refactor gui module to resolve warnings and remove unused imports (NeonGeckoCom#144) Fix unresolved references to GUIWebsocketHandler and write_lock Refactor imports from mycroft to neon_utils and neon_core as possible * Cleanup install dependency resolution (NeonGeckoCom#149) * Refactor to use new dependency resolver Include libpulse-dev system dependency in setup and test setup scripts Remove dependency version patches * Remove commented dependency patches * refactor/bump_ovos_holmes (NeonGeckoCom#95) * holmesV config * Bump HolmesV version Co-authored-by: jarbasal <jarbasai@mailfence.com> Co-authored-by: Daniel McKnight <daniel@neongecko.com> * Add build/release automation (NeonGeckoCom#146) Update version and description parsing in setup.py Reset versioning to match x.04/x.10 release cycle * Increment Version * Remove actions to publish to PyPI until all git dependencies are removed or made available on PyPI (NeonGeckoCom#153) * Increment Version * Add `apt update` to unit tests workflow (NeonGeckoCom#155) * Increment Version * Add default value of `/tmp/neon/ipc` for `ipc_path` (NeonGeckoCom#156) * Increment Version * Refactor and troubleshoot intent handling (NeonGeckoCom#154) * Refactor intent_service.py to isolate Neon features and improve timing metrics * Couple changes to address feedback * Add back `transcribed` timing for backwards compat in skills * Fix logic error in check for `transcribed` timing key * Increment Version * Refactor HolmesV to ovos-core (NeonGeckoCom#157) * Increment Version * Updated Setup Instructions (NeonGeckoCom#139) * Update README to reflect current setup recommendations * Update README developer setup instructions * Increment Version * Release 21.10.0 (NeonGeckoCom#158) * Add test for skills module ready (NeonGeckoCom#162) * Add test for skills module ready * Increase test timeout to 20 minutes for local tests * Increment Version * Handle no plugin in Translator and Detector factory methods (NeonGeckoCom#164) Add default libretranslate plugin to base requirements.txt * Increment Version * Add diagnostic_utils with unit tests (NeonGeckoCom#160) Add neon-upload-diagnostics entrypoint Depreciate neon_core_client module Update dependencies * Increment Version * Refactor gui check to use `is_gui_running` from ovos_utils (NeonGeckoCom#165) * Increment Version * Startup bugfixes, annotations, refactoring (NeonGeckoCom#166) * Fixes typo in run_neon preventing gui, server, and messagebus services from being stopped Add annotations to methods in neon_core.__init__ and exports Mycroft-compatible config from YML configs (closes NeonGeckoCom#159) * Refactor 'Holmes' to 'OVOS' default configs * Address review feedback * Address review feedback * Add TODO comment to evaluate log later * Increment Version * Update requirements.txt spec (NeonGeckoCom#167) Reformat setup.sh * Increment Version * Remove duplicated dependencies in pi.txt (NeonGeckoCom#168) Update neon_cli_client dependency to install from PyPI * Increment Version * Update default wav playback to `play` (NeonGeckoCom#169) * Increment Version * Configuration module tests with bug fixes (NeonGeckoCom#170) * Add configuration module tests with automation Patch ovos_utils method to use proper config * Fix automation file formatting bug * Update neon-utils dependency version * Update neon-utils dependency version * Clear cached config after writing neon changes * Reorg to troubleshoot config issues * Troubleshoot config issues, append .conf to ovos_utils call * Bump ovos_utils and cleanup patches Reorg config tests to resolve config caching errors * Update neon_utils to release version * Increment Version * Increment to 21.10.1 (NeonGeckoCom#171) * Update Test Automation (NeonGeckoCom#173) * Upload test artifacts to close NeonGeckoCom#140 Increase test timeout to account for actions runners Add diagnostic utils tests to GH actions * Formatting cleanup * Increment Version * Add any missing license file headers (NeonGeckoCom#172) Consolidate all LOG imports to neon_utils Refactor superseded `mycroft` imports Mark stt and tts modules as deprecated * Increment Version * Update diagnostic_utils and tests to handle json dumped dicts (NeonGeckoCom#176) * Update diagnostic_utils and tests to handle json dumped dicts * Increase timeout for setup tests * Debug util test failures * Write test config changes to resolve test failures * Add line to debug skill installation errors * revert unit test changes * Increment Version * Remove display module and add optional dependency (NeonGeckoCom#179) * Increment Version * Extract gui module to neon_gui (NeonGeckoCom#181) * Increment Version * Extract Messagebus to separate module and update references (NeonGeckoCom#178) * Extract Messagebus to separate module and update references * Fix dependency version * Move signal bus init into Skill Service class * Remove signal changes to submit via separate PR * Refactor default skill installation (NeonGeckoCom#188) * Add `get_neon_skills_data` to preload skill json Update skill_utils tests * Extend skills timeout to troubleshoot test failure * Refactor skill util tests Fallback to non-cached requests if returned 400 * Refactor skill utils to use OSM/OSI instead of git directly * Increment Version * Fix Setup Test Failures (NeonGeckoCom#197) * Loosen remote dependency specs * Cleanup dependency specs * Test dependency resolution changes * Test dependency resolution changes * Fix typo in requirements * Troubleshooting dependency errors * Troubleshooting dependency errors * Troubleshooting remote dependency errors Try updated pip version * Troubleshooting remote dependency errors * Update amazon translate dependency version * Remove some dependency patches * Replace ovos-utils version patch * loosen ovos_utils version spec * Add back OPM version patch * Troubleshooting skills module test failures * Troubleshooting inconsistent GH test failures * Update dependency specs Add `ready_settings` to troubleshoot test failures * Increase test timeout Update neon.conf default skills URL * Troubleshooting test timeout failures * Rollback changes to troubleshoot GH Actions failures * Update neon-utils dep spec Fix typos in setup_tests uploads * Increment neon-utils version * Update actions uploads to keep logs from all runs * Cleanup setup workflow and add upload of local test logs * Implement core test timeouts * Ensure artifacts are always uploaded * Troubleshooting local test failures * Troubleshoot artifact upload paths * Troubleshoot artifact upload paths * Troubleshoot artifact upload paths * Specify config path in dev setup tests * Replace remote unit tests Comment patch in test setup script * Blacklist skills to suppress logging and troubleshoot failures Fix typo in test results upload * Troubleshoot test failure Cleanup Changes * Troubleshoot local test failure due to model download * Annotate patched speech module test * Increment Version * Initialize Signal Handlers in skills service (NeonGeckoCom#180) * Increment Version * QML File Server (NeonGeckoCom#202) * Add skill http server * Cleanup skill file server and fix license * Refactor file server to qml_file_server.py Update file server to handle system and skill QML resources * Cleanup QML File Server implementation * Increment Version * Normalize language in `handle_utterance` (NeonGeckoCom#204) * Increment Version * Restructure dependencies (NeonGeckoCom#203) * Refactor core module dependencies into an optional spec * Refactor get_messagebus to import from neon_utils * Refactor core module dependencies into an optional spec * Increment Version * Add call to initialize config directory in module init (NeonGeckoCom#205) * Increment Version * Docker Support (NeonGeckoCom#132) * Reduce base dependencies to skills module only Add Dockerfile, overlay files, and updated README documentation * Refactor core modules to an optional extra * Update requirements spec * Add `git` system dependency to skills module for CC skill compat. * Update docker build stage targets Add docker workflows to automation * Update docker step IDs * Add `env` params to Docker workflow * Refactor container image name to "neon-skills" * Fix name in IMAGE_NAME * Add back version automation and remove `workflow_dispatch` option * Troubleshoot docker alpha versioning * Add back workflow_dispatch for testing * Refactor Docker version automation * Fix logic in docker release automation Co-authored-by: Daniel McKnight <daniel@neon.ai> * Increment Version * Update image name in automation to match other core modules (NeonGeckoCom#206) Co-authored-by: Daniel McKnight <daniel@neon.ai> * Increment Version * Remove `neon_gui_service` entrypoint that was moved to `neon_gui` module (NeonGeckoCom#210) Co-authored-by: Daniel McKnight <daniel@neon.ai> * Increment Version * Refactor SkillManager (NeonGeckoCom#208) * Refactor to deprecate override of `load_priority` method and remove `MsmException` handling * Deprecate _get_skill_directories override and update unit tests to test skills load * Fix logical error in unit test update Co-authored-by: Daniel McKnight <daniel@neon.ai> * Increment Version * Fix dependency compatibility (NeonGeckoCom#213) * Lock json_database dependency version * Restrict ovos-utils dependency version * Lock json-database dependency version * Lock OPM version for version compat. * Further restrict OPM dependency * Update json_database dependency to fulfill default skill requirements * Increment version Co-authored-by: Daniel McKnight <daniel@neon.ai> * Update OVOS dependency versions (NeonGeckoCom#212) * Fix dependency compatibility (NeonGeckoCom#213) * Lock json_database dependency version * Restrict ovos-utils dependency version * Lock json-database dependency version * Lock OPM version for version compat. * Further restrict OPM dependency * Update json_database dependency to fulfill default skill requirements * Increment version Co-authored-by: Daniel McKnight <daniel@neon.ai> (cherry picked from commit 611ec32) * Update ovos package dependency versions * Update ovos-core package dependency version * Troubleshoot ovos-core package dependency version * Troubleshoot ovos-core package dependency version Update unit tests to install wheel * Troubleshoot unit test setup * Refactor xdg reference to ovos_utils * Troubleshooting test errors * Refactor one-time config initialization to config module Formatting and code cleanup Update dependencies to test updated package versions * Fix ovos-core version resolution issue * Fix configuration test case Add json-database dependency for alerts skill compat * remove invalid json-database pinned version * Bump core module versions * Troubleshooting * Troubleshooting unit test failures * Troubleshooting automated tests * Increase Python version coverage in tests * Fix parse errors in unit_tests workflow * Fix parse errors in setup_tests workflow * Cleanup requirements Update unit tests * Troubleshoot ovos package compatible versions * Troubleshooting dependency versions and test failures * Testing updated TTS plugin * Update mimic plugin spec * Troubleshooting requirements versioning * Troubleshooting requirements versioning (OPM) Co-authored-by: Daniel McKnight <daniel@neon.ai> * Increment Version * Fix configuration test failures (NeonGeckoCom#215) * Troubleshooting unit test failure * Refactor config.py and fix first-run config errors * Update method name and docstring for clarity * Debug GH test failures * Ensure OVOS config path exists before writing config * Fix typo in config dir creation * Troubleshooting config unit test failures * Refactor configuration tests to better match real-world execution * Cleanup imports Ensure latest ovos_utils * Add ovos_config_assistant log outputs to debug test failures * More debugging of config read * Troubleshooting module detection * Cleanup config initialization * Troubleshoot setup test failures * Remove log added to function in neon-utils Co-authored-by: Daniel McKnight <daniel@neon.ai> * Increment Version * Update docker overlay files for ovos compat (NeonGeckoCom#216) * Update docker overlay files for ovos compat * bump ovos-core dependency spec Co-authored-by: Daniel McKnight <daniel@neon.ai> * Increment Version * Add function to install local skill dependencies with unit tests (NeonGeckoCom#217) * Add util to install local skill dependencies with unit tests * Refactor dependencies and imports * Cleanup test method overrides * Handle reload of mocked modules in tests * Rollback unrelated language module change Co-authored-by: Daniel McKnight <daniel@neon.ai> * Increment Version * ovos_utils config update compat (NeonGeckoCom#218) * Temporarily remove failing ovos_config_assistant call * Revert configuration test changes Update ovos_utils dependency spec * Update config tests for ovos-utils changes * Add wrapper for ovos-utils stack checking compat. * Remove wrapper method and update references Deprecate config wrappers in configuration module * Bump neon_speech dependency spec * Update use_neon_core docstring based on PR feedback Co-authored-by: Daniel McKnight <daniel@neon.ai> * Increment Version * Refactor entrypoints and update Docker to handle skill dependency installation (NeonGeckoCom#209) * Add `cli` module to handle entrypoints Update Dockerfile to handle external skills * Update config tests for ovos-utils changes * Remove added configuration methods * Pin higher ovos-ww-plugin-pocketsphinx version for ovos-utils compat * Increment neon-utils version * Update skill settings path in dockerfile Co-authored-by: Daniel McKnight <daniel@neon.ai> * Increment Version * Refactor skill management code (NeonGeckoCom#219) * Patch ovos-core import error Troubleshoot skills manager changes * Resolve imports to handle patched configuration * Prevent `super` call to deprecated `_emit_converse_error` method * Increment neon-utils version Co-authored-by: Daniel McKnight <daniel@neon.ai> * Increment Version * Add user profile data to messages in intent_service (NeonGeckoCom#198) * Add user profile data to messages in intent_service * Refactor 'profiles' context to 'user_profiles' per OVOS feedback * Increment Version * Skills module tests (NeonGeckoCom#220) * Cleanup deprecated intent_service code Add intent_service unit tests * Cleanup dead code in intent_service.py Update test coverage for NeonIntentService * Add test coverage for SkillStore and SkillService with updated docs and minor bugfixes Updated annotation of skills module * Add test case for skills service * Update tests to resolve import order errors * Handle skill directory creation in NeonSkillManager Rename unit tests for clarity * Troubleshoot configured skill directories in skill_store.py * Troubleshooting skills service * Deprecate skill installation by ID with annotation to fix in OSM * Troubleshoot OSM parsing errors * Add branch spec to test URL Co-authored-by: Daniel McKnight <daniel@neon.ai> * Increment Version * Patch translation bugs (NeonGeckoCom#221) * Pass input language to translation plugin in translator Update intent service to update message.data['lang'] when utterances are translated * Fix language handling for profile context Co-authored-by: Daniel McKnight <daniel@neon.ai> * Increment Version * Add init file to text.modules module to be included in installations (NeonGeckoCom#222) Co-authored-by: Daniel McKnight <daniel@neon.ai> * Increment Version * Docker bugfixes (NeonGeckoCom#223) * Refactor docker overlay files Patch skill dependencies in docker.txt Update skill dependency installation to install before module load * Troubleshooting local speech processing test failures * Troubleshooting local speech processing test failures * Remove outdated deepspeech config from neon.conf * Rollback testing changes Co-authored-by: Daniel McKnight <daniel@neon.ai> * Increment Version * add license tests and workflow (NeonGeckoCom#224) * add license tests and workflow * Update license tests to include additional apt dependencies and license overrides * Update license tests overrides and whitelist * Fix typo in license whitelist * Fix typo in license overrides * Add pyparsing license override Co-authored-by: jarbasai <jarbasai@mailfence.com> Co-authored-by: Daniel McKnight <daniel@neon.ai> * Increment Version * Update license headers to updated 2022 version (NeonGeckoCom#225) Co-authored-by: Daniel McKnight <daniel@neon.ai> * Increment Version * Fix unit test errors (NeonGeckoCom#228) * Set automated test devType to server to resolve speech/audio module test failures * Update setup tests * Remove neon-core-server dependency (is now a standalone package) * Handle errors initializing transcription service Co-authored-by: Daniel McKnight <daniel@neon.ai> * Increment Version * Minor updates and bugfixes, Update docker overlay and documentation (NeonGeckoCom#227) * Update launcher.py with speech service Fix bug in appstore authentication in skill_utils Update gitignore to include local config files Update docker overlay files Add docker-compose with reference config file Update ovos dependency specs Add Quick Start section to README.md * Update docker overlay file to reference main branch of skills * Update neon-utils dependency version * Fix skills image reference * Cleanup logging Update requirements Add docker .env file for default skills * Add first_run param to demo skill settings overlay file Co-authored-by: Daniel McKnight <daniel@neon.ai> * Increment Version * Bump ovos-utils and ovos-core dependency specs (NeonGeckoCom#229) * Bump ovos-utils and ovos-core dependency specs * Update ovos-core dependency spec to release version Co-authored-by: Daniel McKnight <daniel@neon.ai> * Increment Version * Update core module version specs (NeonGeckoCom#230) Update Docker overlay files Co-authored-by: Daniel McKnight <daniel@neon.ai> * Increment Version * Increment to 22.05.0 (NeonGeckoCom#231) * Fix Docker Release Workflow (NeonGeckoCom#235) * Increment Version * Revert Version Change (NeonGeckoCom#237) * Remove pillow dependency from test skill to resolve dependabot (NeonGeckoCom#239) Co-authored-by: Daniel McKnight <daniel@neon.ai> * Increment Version * Cleanup module dependencies (NeonGeckoCom#238) Co-authored-by: Daniel McKnight <daniel@neon.ai> * Increment Version * Handle Core Dependency constraints in skill installation (NeonGeckoCom#241) * Write constraints file before skill installation with unit tests Resolve unhandled exception raised in intent_service.py * Fix constraints to remove unsupported optional extras spec * Fix unit tests constraints test case * Update dependency constraints to walk top-level dependencies * Download skills that fail to install normally * Add docstring to added function Co-authored-by: Daniel McKnight <daniel@neon.ai> * Increment Version * Skip attempts to install local skill if __init__.py not present (NeonGeckoCom#242) * Skip attempts to install skills if __init__.py not present * Fix path errors in local skill installation Co-authored-by: Daniel McKnight <daniel@neon.ai> * Increment Version * Override converse to enable for all active skills (match legacy behavior) (NeonGeckoCom#243) Co-authored-by: Daniel McKnight <daniel@neon.ai> * Increment Version * Handle emitted profile updates in intent_service.py (NeonGeckoCom#244) * Handle emitted profile updates in intent_service.py * Loosen psutil dependency for ovos-core compat. Co-authored-by: Daniel McKnight <daniel@neon.ai> * Increment Version * Update default coquiTTS plugin version in Docker (NeonGeckoCom#245) Ensure lingua-franca is completely uninstalled in Dockerfile Co-authored-by: Daniel McKnight <daniel@neon.ai> * Increment Version * Prevent skill installation from installing lingua-franca (NeonGeckoCom#246) * Prevent skill installation from installing lingua-franca and remove dockerfile patch * Update neon-utils spec to fix config bug Co-authored-by: Daniel McKnight <daniel@neon.ai> * Increment Version * Docker Fixes (NeonGeckoCom#247) * Update config path to use envvars * Bump neon_utils dependency Co-authored-by: Daniel McKnight <daniel@neon.ai> * Increment Version * Override `resolve_resource_file` to handle neon-core package resources (NeonGeckoCom#249) * Override mycroft.util.file_utils.resolve_resource_file with unit tests * Update tests to cover all expected resources * Add missing sound resources * Add missing neon.voc resources Co-authored-by: Daniel McKnight <daniel@neon.ai> * Increment Version * Handle removal of broken symlinks in QML File Server (NeonGeckoCom#250) Co-authored-by: Daniel McKnight <daniel@neon.ai> * Increment Version * Add manual workflow to build/push an image with updated skills * Increment Version Co-authored-by: NeonJarbas <59943014+NeonJarbas@users.noreply.github.com> Co-authored-by: jarbasal <jarbasai@mailfence.com> Co-authored-by: JarbasAI <33701864+JarbasAl@users.noreply.github.com> Co-authored-by: NeonDaniel <NeonDaniel@users.noreply.github.com> Co-authored-by: Daniel McKnight <daniel@neon.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.