-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Module Services, Mycroft-compatible Config, ovos-core 0.0.4 #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update launcher to handle audio service Update ovos-core dependency spec * Fix internal ovos-core dependency conflict * Update neon_messagebus dependency version for compat. * Bump audio module dependency Co-authored-by: Daniel McKnight <daniel@neon.ai>
NeonDaniel
changed the title
Refactor skills service to extend
Update Module Services, Mycroft-compatible Config
Jul 6, 2022
Thread
(#254)* Update config references to use Configuration class * Cleanup config init Update default config with new default values Troubleshoot test failures * Update setup tests to check proper configuration * Update configuration tests to account for XDG config changes * Update default config Fix config init and annotate process Fix configuration test bugs * Bump ovos-core dependency spec * Troubleshooting GH actions failures * Fix core modules dependency spec for compat with base dependencies * Troubleshooting test failures * Update neon-utils dependency spec * Add `patch_config` function with unit test * Updated config handling in skills service Update skills module unit tests * Bump ovos-core dependency to troubleshoot unit testing * Remove deprecated `test_signal_dir` test of deprecated ipc_dir methods * Bump polly tts spec * Bump coqui spec in default docker config * Update default config to include skills `extra_directories` spec * fix `safe_mycroft_config` to load proper config stack * Handle determining skill directory from config with default fallback * Troubleshooting config-related test failures * Handle default skill_dir determination * Troubleshooting skills module unit tests * Mark setup tests as legacy support * Increment remote tts dependency * Troubleshoot `skill_dir` determination * Troubleshoot LOG_DIR default writable path * Remove extra trailing comma in default config * Update skills module test to ensure config matches expectation * Troubleshooting auto_update unit test failures * Set log dir in legacy setup tests for unit test log uploading * Fix test error from refactor * Fix invalid workflow job IDs * Bump minimum core module versions * Remove deprecated diagnotic utils * Update skills config references Remove diagnostic util test cases * Resolve skills module unit test failures * Troubleshooting config * Troubleshooting skills module test failures * Troubleshooting skills module test failures * Troubleshooting config updates * Fix config updates and skills unit test failures * Cleanup config tests * Troubleshooting automated test failures * Troubleshooting automated test failures * Troubleshooting automated test failures * Troubleshooting automated test failures * Troubleshooting config init in test modules * Override skill settings in TestSkillStore * Troubleshoot test failure * Update default config to .yaml * Update default config to .yaml * Handle exception creating skill directory * Cleanup configuration changes and tests * Bump ovos-core dependency version for yml config compat * Fix ovos-core conflicting dependency spec * Troubleshooting core setup test errors * Update config load to new method * Update setup unit tests * Fix path/str comparison * Troubleshooting test failures * Troubleshooting skill installation * Handle mycroft default ['skills']['directory'] config value * Add config upload to setup tests * Fix path to config file in upload step * Update diagnostic utils to handle xdg log files and mycroft-style configuration * Fix typo in uploaded test logs * Update package_data to handle any default config file format * Update default config and core module dependency specs * Fix typo in core module dependency spec * Fix indent error in MQ default config * Fix `log_dir` config key * Remove deprecated config references Update default config * ovos_config refactor * Update docker overlay files, dependencies, and docs for config changes * Update docker overlay files Update dependencies for configuration bugfixes * Add exceptiongroup license override * Name skill_manager thread * Update ovos-config dependency spec * Update ovos-core dependency spec * Bump google STT plugin to compatible version * Remove deprecated config references * Update neon-utils dependency spec * Update dependency versions to alpha releases * Bump neon-cli-client dependency spec * Update dependency specs * Troubleshooting local test dependency resolution Troubleshooting config test failures * Annotate patch in config reloading Remove extra call to `configuration.reload` in skills service Remove python 3.6 unit tests * Bump mimic plugin version * Cleanup test failures * Add config test * Troubleshoot logging in setup test failures * Troubleshoot logging in setup test failures * Update config handling and bump package versions * Update unit test version coverage Troubleshooting run_neon test failures * Isolate automated test failures * Testing with neon_utils patch * Cleanup init Add neon_utils to skill dependency blacklist to prevent breaking core compat. * Fix typos in skill dependency exclusions * Patching neon-utils constraint in skill installation * Replace run tests * Resolve unit test failures * Ensure config file exists before writing changes in `patch_config` * Fix deprecated import error in TestSkillManager * Replace startup logging to file * Troubleshooting setup log upload * Troubleshooting setup test failures * Troubleshooting setup test failures * Fix envvar bug in test_run_neon.py * Troubleshooting config loading in tests * Cleanup changes and troubleshoot remote test failure * Troubleshooting GH actions config artifact upload * Fix typo in config path to upload * Cleanup changes Add unit test for new method `get_default_skills_dir` * Troubleshooting config file uploads * Remove GH Action config file uploading Co-authored-by: Daniel McKnight <daniel@neon.ai>
Co-authored-by: Daniel McKnight <daniel@neon.ai>
* Bump dependencies Add logging to intent service to debug intent handling * Override default hotwords config * Cleanup logging Remove priority skills from default config Add utterance handler tests to skills module unit tests * Remove log * Update ovos-config dependency spec Add back config test * Fix typo in updated configuration test Co-authored-by: Daniel McKnight <daniel@neon.ai>
Co-authored-by: Daniel McKnight <daniel@neon.ai>
* Handle GUI pages from plugin skills * Fix plugin skill UI content availability * Add initial plugin skill dependencies as optional extras Add additional settings overlay for plugin homescreen Update dockerfile to install skills via optional extras spec * Update skill dependency lists Add more skills extras to Dockerfile * Cleanup GUI server handling * Add instructions skill with default config overlay * Remove deprecated skills config with default plugin skills * Fix typo in QML server startup * Fix skills module test failure * Cleanup config reference Annotate skill utilities moved to plugins * Update instructions skill dependency spec Update default homescreen to 'lite' package * Add docstring to new method Add back Docker installation of configured skills for jokes skill compat. * Update skill directory handling to implement ovos-utils methods * Bump ovos-config dependency * Add .keep files for test skill directories in unit tests * Reorder SkillsService init so GUI server can handle installed skills Co-authored-by: Daniel McKnight <daniel@neon.ai>
* Fix homescreen skill dependency spec Add unit test for extras installation * Move module installation tests to `setup_tests` * Troubleshoot install test failures * Remove Python3.10 install test case Co-authored-by: Daniel McKnight <daniel@neon.ai>
* Include TTS plugin and dependencies for Demo skill * Update demo skill dependency Rollback MQ Config change Co-authored-by: Daniel McKnight <daniel@neon.ai>
* neon_transformers * Cleanup rebased changes Update base requirements.txt * Update transformer unit tests Add default `supported_langs` config for translator plugin * Update unit tests to match documented priority handling Co-authored-by: jarbasai <jarbasai@mailfence.com> Co-authored-by: Daniel McKnight <daniel@neon.ai>
…#270) Co-authored-by: Daniel McKnight <daniel@neon.ai>
* Add note regarding docker user permissions * Add newgrp call to example to reload permissions in current shell * Add note regarding hidden files in quick start Update GUI link to OVOS forked version Update config file referenced to new format * Revert GUI link to appropriate repo Co-authored-by: Daniel McKnight <daniel@neon.ai>
NeonDaniel
changed the title
Update Module Services, Mycroft-compatible Config
Update Module Services, Mycroft-compatible Config, ovos-core 0.0.4
Aug 19, 2022
* Update dependencies to stable versions * Add neon-mana-utils dev dependency Bump OSM to stable version * Add skill version specs * Update speech and audio modules to stable versions Co-authored-by: Daniel McKnight <daniel@neon.ai>
NeonDaniel
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add basic install tests to detect dependency conflicts
Mark setup script tests as deprecated
Deprecate Python3.6 tests and add Python3.10
Update docker image to pip install skills
Update quick start documentation
Refactor config to ovos-compatible structure
Update launcher to wrap actions in
main
methodDeprecate bundled processing_modules (moved to plugins)
Refactor utterance text parsers to UtteranceTransformersService
Update skills service to extend Thread
Refactor Skills GUI File Server to support plugin skills
Improved error handling around OSM Skill Installation (Clone skill if dependencies conflict)
Cleanup dependencies
Specify skills as optional Python dependencies
Test Changes
Rewrite config tests to account for refactor
Updated config handling in tests
Remove Deprecated tests/TODOs for deprecated core modules
Add Tests for SkillsService
Refactor skills module tests to account for config and skill directory changes