Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ovos-core 0.0.8 compat. #411

Merged
merged 4 commits into from
May 10, 2024
Merged

ovos-core 0.0.8 compat. #411

merged 4 commits into from
May 10, 2024

Conversation

NeonDaniel
Copy link
Member

@NeonDaniel NeonDaniel commented Apr 15, 2023

Description

Cleanup patches and imports to better implement changes in ovos-core 0.0.8aX

Issues

Continues #641

Other Notes

Needs NeonGeckoCom/neon-utils#523

@NeonDaniel NeonDaniel changed the title Updated ovos-workshop compat. ovos-core 0.0.8 compat. Apr 15, 2023
@NeonDaniel NeonDaniel marked this pull request as draft April 15, 2023 02:25
@NeonDaniel NeonDaniel force-pushed the FEAT_OvosWorkshopCompat branch from 8f4bd06 to 059be71 Compare December 30, 2023 00:14
@NeonDaniel NeonDaniel force-pushed the FEAT_OvosWorkshopCompat branch 3 times, most recently from da33390 to 748f8f5 Compare March 14, 2024 01:15
NeonDaniel and others added 2 commits May 9, 2024 14:34
Resolve test failure from upstream refactor

Troubleshooting ovos-backend-client fix

Add import to apply module patch

Remove extra exception handling
Update patching in unit test

Update patching in tests

More test failure troubleshooting

More test failure troubleshooting

More test failure troubleshooting

More test failure troubleshooting

Mark `decorators` module as deprecated
Update imports from `mycroft` to `ovos-core`
Remove invalid test case

Troubleshoot test failures
Replace skill settings patch

More test failure troubleshooting

Update dependencies to troubleshoot backwards-compat

Update core module dependencies

Update ovos-core patching

Remove dependency patches

Update patches and ovos-core version to latest alpha

Update ovos_workshop dependency version and add comon_query patching
Replace remaining `mycroft` imports with new package paths
Cleanup unused imports
@NeonDaniel NeonDaniel force-pushed the FEAT_OvosWorkshopCompat branch from 748f8f5 to 4d3b870 Compare May 9, 2024 21:41
@NeonDaniel NeonDaniel marked this pull request as ready for review May 10, 2024 16:37
@NeonDaniel NeonDaniel merged commit 2a4665c into dev May 10, 2024
20 checks passed
@NeonDaniel NeonDaniel deleted the FEAT_OvosWorkshopCompat branch May 10, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant