Pre-render tabs in accordion mode

typo Don't update fallback selection in accordion mode Update pkgs Prevent selecting fallback on invalid selection when the fallback is already selected
Neovici · Aug 15, 2018 · eae0db2 · eae0db2
1 parent fe7896b
commit eae0db2
Show file tree

Hide file tree

Showing 4 changed files with 9,990 additions and 1,025 deletions.
diff --git a/cosmoz-tab.js b/cosmoz-tab.js
@@ -64,7 +64,8 @@
 			'_notifyProperty("hidden", hidden)',
 			'_notifyProperty("disabled", disabled)',
 			'_notifyProperty("heading", heading)',
-			'_notifyProperty("badge", badge)'
+			'_notifyProperty("badge", badge)',
+			'_onAccordionChangedRender(accordion)'
 		],
 
 		listeners: {
@@ -123,7 +124,12 @@
 
 		resizerShouldBeNotified(resizable) {
 			return resizable.parentNode !== this.$.header;
-		}
+		},
 
+		_onAccordionChangedRender(accordion) {
+			if (accordion) {
+				this.render();
+			}
+		}
 	});
 }());
diff --git a/cosmoz-tabs.js b/cosmoz-tabs.js
@@ -222,7 +222,9 @@
 			if (item.invalid && item === selected) {
 				const fallback = this._valueToItem(this.fallbackSelection);
 				fallback.__invalidFallbackFor = item;
-				this.select(this.fallbackSelection);
+				if (fallback !== item) {
+					this.select(this.fallbackSelection);
+				}
 			} else if (!item.invalid && selected && item === selected.__invalidFallbackFor) {
 				selected.__invalidFallbackFor = null;
 				this.select(this._valueForItem(item));