Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iron-collapse removed, div with id content css transition. #47

Merged
merged 10 commits into from
May 17, 2018
Merged

Iron-collapse removed, div with id content css transition. #47

merged 10 commits into from
May 17, 2018

Conversation

programmer4web
Copy link
Contributor

@programmer4web programmer4web commented Apr 23, 2018 •
edited
Loading

Replaced iron-collapse in cosmoz-tab.
Replaced iron-collapse in cosmoz-tab-card.
Tests updated.
es6 updates for accordion.html tests.
fixes #46
More tests to keep up with the code coverage decrease. Done.

@programmer4web programmer4web force-pushed the feature/NEOV-205-replace-iron-collapse branch 2 times, most recently from f8c1055 to b840a92 Compare April 24, 2018 12:22
@programmer4web
cosmoz-tab collapse animation
2028e71 
iron-collapse removed;
@programmer4web
cosmoz-tab-card updated
9c9f0cd 
iron-collapse removed;
@programmer4web
css , js fixes
3a2c71b
@programmer4web
accordion tests updated
59e640d 
accordion tests implemented with getComputedStyle, getPropertyValue
@programmer4web programmer4web force-pushed the feature/NEOV-205-replace-iron-collapse branch from b840a92 to 59e640d Compare April 24, 2018 12:33
@programmer4web programmer4web changed the title [WIP] replace iron-collapse with css transition Iron-collapse removed, div with id content css transition. Apr 24, 2018
@megheaiulian
Copy link
Collaborator

Needs more tests to keep up with the code coverage decrease.

megheaiulian
megheaiulian reviewed Apr 28, 2018
View reviewed changes
cosmoz-tab.html Outdated
:host([has-cards][accordion]) #content {
display: block;
:host(:not([has-cards])[accordion]) #content {
transition-duration: var(--cosmoz-tab-collapse-transition-duration, 300ms);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--cosmoz-tab-collapse-transition-duration should be --cosmoz-tab-transition-duration similar to the variable for tab-card

@programmer4web
transition-duration variable for tab, card
3759e5d 
--cosmoz-tab-transition-duration
@programmer4web programmer4web changed the title Iron-collapse removed, div with id content css transition. [WIP] Iron-collapse removed, div with id content css transition. May 4, 2018
@programmer4web programmer4web force-pushed the feature/NEOV-205-replace-iron-collapse branch from 0113644 to d6585c7 Compare May 4, 2018 15:35
@programmer4web
test for function _valueForItem
43e6544 
test if function _valueForItem handles null item
_valueForItem handles null attr


resizerShouldBeNotified test
@programmer4web programmer4web force-pushed the feature/NEOV-205-replace-iron-collapse branch from d6585c7 to 43e6544 Compare May 4, 2018 15:57
@programmer4web programmer4web force-pushed the feature/NEOV-205-replace-iron-collapse branch from 16aeefd to 6ea4355 Compare May 15, 2018 06:25
@programmer4web
tests to increase code coverage
7322d69 
_onSelectedTransitionEnd test
_normalizeValue test


normalizeValue test

attrForSelected null
@programmer4web programmer4web force-pushed the feature/NEOV-205-replace-iron-collapse branch from 6ea4355 to 7322d69 Compare May 15, 2018 06:35
@programmer4web
accordion mode test
07d3acb 
last selectedItem remains selected
@programmer4web programmer4web changed the title [WIP] Iron-collapse removed, div with id content css transition. Iron-collapse removed, div with id content css transition. May 15, 2018
@programmer4web
Copy link
Contributor Author

@megheaiulian This is ready for review. (more tests added to keep up with the code coverage)

@nomego
Copy link
Contributor

nomego commented May 16, 2018

@megheaiulian review approval still stands?
What is this for, primarily? Fixes bugs with iron-collapse, performance gain, something else?

@megheaiulian
Copy link
Collaborator

@nomego On desktop (non accordion) iron-collpase wasn't used at all but still handled and triggered some resize events. Since it's not needed we just do the transitions with css on mobile.

@nomego
Copy link
Contributor

nomego commented May 16, 2018

Does this still trigger "tab activated" when expanding "tab as card" on mobile?

@megheaiulian
Copy link
Collaborator

@nomego This should work exactly as before. The transition part was already totally separated from the activated event. Normally it just changed the isSelected (with reflectToAttribute) property and iron-collapse used that for a transition. Now we use isSelected to trigger a CSS transition.

@nomego nomego merged commit 86ce740 into Neovici:master May 17, 2018
@programmer4web programmer4web deleted the feature/NEOV-205-replace-iron-collapse branch May 18, 2018 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@megheaiulian megheaiulian megheaiulian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

replace iron-collapse
3 participants
@programmer4web @megheaiulian @nomego