Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 移除 node-sass 使用 #13604

Merged
merged 8 commits into from
Apr 10, 2023
Merged

feat: 移除 node-sass 使用 #13604

merged 8 commits into from
Apr 10, 2023

Conversation

ZakaryCode
Copy link
Contributor

@ZakaryCode ZakaryCode commented Apr 7, 2023 •
edited
Loading

这个 PR 做了什么? (简要描述所做更改)

  • 移除 node-sass 使用
  • 更新相关测试依赖

由于当前 sass 锁版本 #11983 (comment) ，暂不考虑移除根目录 @types/sass 依赖，后续升级可以将其下方到对应包内（types 类型会自动提升到根目录依赖）

这个 PR 是什么类型? (至少选择一个)

这个 PR 涉及以下平台:

  • 移动端（React-Native）

@ZakaryCode ZakaryCode requested a review from zhiqingchen April 7, 2023 10:26
@zhiqingchen
Copy link
Member

@ZakaryCode CI 仍有问题

@taro-bot2 taro-bot2 bot mentioned this pull request Apr 8, 2023
Closed
@ZakaryCode ZakaryCode merged commit bd43b00 into next Apr 10, 2023
@ZakaryCode ZakaryCode deleted the fix/sass branch April 10, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhiqingchen zhiqingchen zhiqingchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
H5
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

taro能支持node16及其以上版本，现在node-sass报错不兼容
2 participants
@ZakaryCode @zhiqingchen