Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): 支持更改 CLI 展示的模板名称 #15940

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Conversation

koppthe
Copy link
Contributor

@koppthe koppthe commented Jun 20, 2024

这个 PR 做了什么? (简要描述所做更改)

  • 调整 CLI 模板展示逻辑,支持自定义模板名称

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue: fix #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他,请描述(Other, please describe):

这个 PR 涉及以下平台:

  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台(QuickApp)
  • Web 平台(H5)
  • 移动端(React-Native)
  • 鸿蒙(harmony)

"adm-zip": "^0.4.13",
"axios": "^1.6.8",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node 18 应该可以用 fetch 了吧

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.x还支持node16,4.x可以吧这个去掉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是的,但这块的代码逻辑是 4.x 里面的,只是同步一下,后续可以优化一下,没必要用 axios

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.51%. Comparing base (a8ac196) to head (2bf114b).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             main   #15940    +/-   ##
========================================
  Coverage   56.51%   56.51%            
========================================
  Files         500      500            
  Lines       22767    22767            
  Branches     5750     5758     +8     
========================================
  Hits        12866    12866            
- Misses       8696     8936   +240     
+ Partials     1205      965   -240     
Flag Coverage Δ
taro-cli 57.47% <ø> (-17.53%) ⬇️
taro-runner 54.00% <ø> (ø)
taro-runtime 79.39% <ø> (ø)
taro-web 40.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 60 files with indirect coverage changes

@ZEJIA-LIU ZEJIA-LIU merged commit c12054b into main Jun 20, 2024
26 checks passed
@ZEJIA-LIU ZEJIA-LIU deleted the feat/cli-optimize branch June 20, 2024 05:39
This was referenced Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants