-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): 支持更改 CLI 展示的模板名称 #15940
feat(cli): 支持更改 CLI 展示的模板名称 #15940
Conversation
"adm-zip": "^0.4.13", | ||
"axios": "^1.6.8", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Node 18 应该可以用 fetch 了吧
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3.x还支持node16,4.x可以吧这个去掉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
是的,但这块的代码逻辑是 4.x 里面的,只是同步一下,后续可以优化一下,没必要用 axios
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15940 +/- ##
========================================
Coverage 56.51% 56.51%
========================================
Files 500 500
Lines 22767 22767
Branches 5750 5758 +8
========================================
Hits 12866 12866
- Misses 8696 8936 +240
+ Partials 1205 965 -240
Flags with carried forward coverage won't be shown. Click here to find out more. |
这个 PR 做了什么? (简要描述所做更改)
这个 PR 是什么类型? (至少选择一个)
这个 PR 涉及以下平台: