-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(weapp): 修复微信 Map 组件在 Android 环境下且小程序基础库 v3.4.10+ 出现的属性配置异常 #16603
Conversation
1. 优化 isNumber 判断逻辑; 2. 修复微信 Map 组件 setting 属性的默认设置值问题;
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16603 +/- ##
=======================================
Coverage 58.51% 58.51%
=======================================
Files 466 466
Lines 27109 27115 +6
Branches 5959 5956 -3
=======================================
+ Hits 15862 15866 +4
- Misses 9903 9925 +22
+ Partials 1344 1324 -20
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
大佬牛逼
咨询一下,目前这个问题修复了之后,Taro历史版本是否是自己做兼容? |
是的,旧版本需要手动添加 |
了解,看上面这个问题被合并到4.0.7分支下,后续是不是Taro 4.0.7 及以后版本不需要做这类的容错 |
这个 PR 做了什么? (简要描述所做更改)
setting
属性的默认设置值问题;这个 PR 是什么类型? (至少选择一个)
这个 PR 涉及以下平台: